Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
The jQuery dependency here is rather unnecessary. As many projects want to get rid of jQuery I think it would make sense to update this module.
As this module has a dependency on theme_breakpoint_js you will also need this patch to get rid of jQuery: https://www.drupal.org/project/theme_breakpoints_js/issues/2974508
Comment | File | Size | Author |
---|---|---|---|
#3 | adentity_remove_jQuery-2974510-3.patch | 25.85 KB | arthur_lorenz |
adentity_remove_jQuery.patch | 25.35 KB | arthur_lorenz | |
Comments
Comment #2
mxhThanks for the patch, seems a little work is needed:
1.
var ad_entity_id = JSON.stringify(container.dataset.adEntity);
Is a wrap by JSON.stringify necessary here?
2.
element.dataset
is not compatible with IE < 11. We need at least compatibility with IE 10, i.e. ECMAScript 5 (5.1 is ok too).dataset
does not belong to it. See also https://developer.mozilla.org/en-US/docs/Learn/HTML/Howto/Use_data_attri....Using a proper polyfill would be ok too.
Please make sure the whole patch is conform to ECMAScript <= 5.1.
Comment #3
arthur_lorenz CreditAttribution: arthur_lorenz at drunomics commentedGood catch, fixed both issues!
Comment #4
mxhComment #6
mxhAbove commit includes heavily refactored JS code. This should be well tested before the next release, but I guess there's not enough time for it.
Will try to test as far as I can. Test contributions (manually or automated) are highly appreciated.
Comment #8
mxhIncluded in 1.0-beta17. Feel free to re-open if something is missing or wrong.