Problem/Motivation

The new repository does not have any gitlab-ci to run tests.

Proposed resolution

Add a .gitlab-ci.yml file (https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr...)

Consider fixing phpunit pipeline if there's number of failure isn't in huge number.

Issue fork acquia_optimize-3505038

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rajeshreeputra created an issue. See original summary.

rajeshreeputra opened merge request !2

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Status: Active » Needs review
chandansha’s picture

chandansha commented

i have checked MR 2 @rajeshreeputra ADDED gitlab-ci template.
some of teste throw warning and some tests are failed.
I Leave status as it is.
RTBC+1.
THANKS!!

ankitv18 made their first commit to this issue’s fork.

ankitv18’s picture

ankitv18 commented
Version: 1.0.0 » 1.1.0
ankitv18’s picture

ankitv18 commented
Issue summary: View changes
ankitv18’s picture

ankitv18 commented
Status: Needs review » Needs work
ankitv18’s picture

ankitv18 commented
Status: Needs work » Needs review

Tests are also fixed as a part of this issue ~~ now pipelines are passing, hence moving into NR.

vishalkhode’s picture

vishalkhode commented
Status: Needs review » Reviewed & tested by the community

Reviewed changes, looks good to me. Hence, RTBC.

vipin.mittal18 credited balsama.

vipin.mittal18’s picture

vipin.mittal18
He/Him
Primary language English
Location Greater Noida, India
commented
Status: Reviewed & tested by the community » Fixed
vipin.mittal18’s picture

vipin.mittal18
He/Him
Primary language English
Location Greater Noida, India
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.