acquia_contenthub.entity_config is not respected by \Drupal\acquia_contenthub\EntityManager::getAllowedEntityTypes() [#2822033]

acquia_contenthub.entity_config is not respected by \Drupal\acquia_contenthub\EntityManager::getAllowedEntityTypes().

In fact, the only thing that respects acquia_contenthub.entity_config is \Drupal\acquia_contenthub\EntityManager::isEligibleEntity(). But that expects an actual Entity object to be passed.

So how is ResourceRoutes supposed to respect the configuration, if the internal API does not support this?

Also: why "allowed" vs "eligible"?

Comments

Comment #1

25 October 2016 at 16:19

Wim Leers created an issue. See original summary.

Comment #2

abarrios CreditAttribution: abarrios commented 25 October 2016 at 20:07

I see what you mean and you are right, there is a bug right there. Currently we do not have a method to get the list of configured entities from "acquia_contenthub.entity_config". The only one method that obtains the list from the configuration is isEligibleEntity().

The way how ResourceRoutes is obtaining the list of "configured" entities is actually wrong.

The list of configured entities should be obtained from the configuration, not from \Drupal\acquia_contenthub\EntityManager::getAllowedEntityTypes().

Also:
Allowed: List of entity types that are allowed to be configurable in the interface (excludes some types which cannot be enabled in the configuration).
Eligible: An entity type that has been selected to be exported to content hub.

Comment #3

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers at Acquia commented 26 October 2016 at 06:21

i.e. this configuration is not being respected:

entities:
  block_content:
    basic:
      enable_index: 0
      enable_viewmodes: 0
      rendering: {  }
  file:
    file:
      enable_index: 0
      enable_viewmodes: 0
      rendering: {  }
  node:
    article:
      enable_index: 1
      enable_viewmodes: 1
      rendering:
        rss: rss
    page:
      enable_index: 1
      enable_viewmodes: 0
      rendering:
        teaser: teaser
  taxonomy_term:
    tags:
      enable_index: 0
      enable_viewmodes: 0
      rendering: {  }
user_role: anonymous

… but also, that configuration has some significant flaws:

it lists all entity types… (except some hardcoded excluded ones) but would fail if a new entity type is added
it uses 0/1 instead of false/true
it cannot list dependencies on the bundle entities

This should be converted to use config entities, for similar reasons as REST (see #2308745: Remove rest.settings.yml, use rest_resource config entities)