Variable acquia_subscription_data isn't context-sensitive [#2826384]

Sometimes, acquia_agent_check_subscription() gets called with a "no_heartbeat" option which returns different subscription data, but when we cache the subscription information with variable_set(), we don't care about this argument.

This specifically sometimes breaks Acquia Search configuration, because it can't determine the Solr indexes' Hostname to use, and falls back to using "search.acquia.com" which might be the wrong domain.

Comment	File	Size	Author
#5	2826384-5-acquia_search_multi_subs.patch	990 bytes	dmitrii
#5	7.x-2.x: PHP 5.3 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks
#2	2826384-context-sensitive-acquia_subscription_data-7.x-2.x.patch	703 bytes	janusman
#2	7.x-2.x: PHP 5.3 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

10 November 2016 at 16:33

janusman created an issue. See original summary.

Comment #2

janusman CreditAttribution: janusman at Acquia commented 10 November 2016 at 16:34

File	Size
2826384-context-sensitive-acquia_subscription_data-7.x-2.x.patch	703 bytes
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks

Patch for review. Haven't tested yet though!

Comment #3

janusman CreditAttribution: janusman at Acquia commented 11 November 2016 at 14:57

Issue summary:

View changes

Comment #4

janusman CreditAttribution: janusman at Acquia commented 16 November 2016 at 22:36

Priority:

Normal

» Major

Kind of a problem, so raising to Major.

Comment #5

dmitrii CreditAttribution: dmitrii as a volunteer and at Acquia commented 17 November 2016 at 13:24

File	Size
2826384-5-acquia_search_multi_subs.patch	990 bytes
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks

It looks like you're using the acquia_search_multi_subs module and issue is related to the acquia_search_multi_subs module and was introduced by me in
http://cgit.drupalcode.org/acquia_search_multi_subs/commit/?id=9b71c72
Attached patch should fix the issue.
Let me know if it helps.

Comment #6

dmitrii CreditAttribution: dmitrii as a volunteer and at Acquia commented 17 November 2016 at 13:25

Status:

Active

» Needs review

Comment #7

janusman CreditAttribution: janusman at Acquia commented 21 November 2016 at 17:26

Thanks for that patch! I will put it onto acquia_search_multi_subs ....

However, it still feels wrong that acquia_agent_check_subscription() is caching a result of something that has an argument, while disregarding that argument. Can I get a second look at that? :)

Comment #8

dmitrii CreditAttribution: dmitrii at Acquia commented 22 November 2016 at 06:19

Status:

Needs review

» Needs work

Yeah, now I see. We should include this patch. Probably it's necessary to add some logic to avoid situation when the module might be without configuration.
I'll discuss this with the team.