id.tarzanych has ported ACL to D8 in #2495027: ACL Drupal 8.x Port — THANK YOU!

This issue is intended to record testing progress.

We need specific testing in the following areas:

  1. Running under D8 (user view)
  2. Migration from D7
  3. Direct migration from D6
  4. Serving D8 client modules (developer view)

Unfortunately, we do not have Devel Node Access for D8 yet (#2380335: Devel Node Access block is broken).

Comments

salvis created an issue. See original summary.

salvis’s picture

salvis
he/his
commented
Title: ACL for D8 » ACL for D8 — ALPHA1
Version: 8.x-1.x-dev » 8.x-1.0-alpha1
Issue summary: View changes
Priority: Critical » Major

We have ALPHA1 of ACL.

It has all the functionality of the D7 version, including migration from D7 and D6.

Please test this version and provide feedback, both good and bad:

IF it works for you, let us know by adding a note to THIS issue here.

IF YOU FIND A BUG, please check the issues queue, and if it hasn't been reported yet, then OPEN A NEW ISSUE!
Do NOT add bug reports to this issue here.

salvis’s picture

salvis
he/his
commented
Issue summary: View changes
id.tarzanych’s picture

id.tarzanych commented

Tested with Drupal 8 RC2

abarpetia’s picture

abarpetia commented

Tested with Drupal 8.1.1. ACL module running smoothly and currently providing all functionality of D7.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Title: ACL for D8 — ALPHA1 » ACL - ALPHA2
Category: Task » Plan

retitling it and converted this to plan. Let's create the followup issues for the tests that are needed to get the alpha2 released.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Title: ACL - ALPHA2 » ACL - Alpha2 release
rwmanos’s picture

rwmanos commented

While migrating with Drush 8.1.15 a Drupal 7.56 to Drupal 8.4.4 website with acl-8.x-1.0-alpha1 installed, the following error occurs:

Found command: migrate-upgrade (commandfile=migrate_upgrade) [0.75 sec, 21.92 MB]                         [bootstrap]
Calling hook drush_migrate_upgrade [0.84 sec, 25.61 MB]                                                       [debug]
PHP Fatal error:  Declaration of Drupal\acl\Plugin\migrate\destination\AclList::fields() must be compatible with Drupal\migrate\Plugin\MigrateDestinationInterface::fields(Drupal\migrate\Plugin\MigrationInterface $migration = NULL) in /drupal/8.4.4/sites/d8-blank.mydomain.com/modules/acl/src/Plugin/migrate/destination/AclList.php on line 22

Fatal error: Declaration of Drupal\acl\Plugin\migrate\destination\AclList::fields() must be compatible with Drupal\migrate\Plugin\MigrateDestinationInterface::fields(Drupal\migrate\Plugin\MigrationInterface $migration = NULL) in /drupal/8.4.4/sites/d8-blank.mydomain.com/modules/acl/src/Plugin/migrate/destination/AclList.php on line 22
Drush command terminated abnormally due to an unrecoverable error.                                        [error]
Error: Declaration of Drupal\acl\Plugin\migrate\destination\AclList::fields() must be compatible with
Drupal\migrate\Plugin\MigrateDestinationInterface::fields(Drupal\migrate\Plugin\MigrationInterface
$migration = NULL) in
/drupal/8.4.4/sites/d8-blank.mydomain.com/modules/acl/src/Plugin/migrate/destination/AclList.php,
line 22 [4.41 sec, 45.08 MB]
oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
commented

@rwmanos Use dev branch, this is more stable than alfa.

salvis’s picture

salvis
he/his
commented

@rwmanos: Please try the -dev version. If it works, please report here, if it doesn't, then OPEN A NEW ISSUE. We cannot fix bugs in this generic thread.

rwmanos’s picture

rwmanos commented

The Fatal error does not occur with the -dev version, indeed. Please release a new version.

To give you some background, we have to migrate many sites so we are using automation scripts. The process checks all installed Drupal 7 modules and performs drush dl for each one of them at the new Drupal 8 site. Then, if there is a migration path -which is true for acl- it enables it. Eventually the migration fails completely due to this fatal error and we have to intervene.

The point is we do not use 'dl --dev' because dev is normally the unstable branch.

Another option is to remove the supported tag from the alpha version so drush dl ignores it like it does, for instance, for views:

drush @$d8_site dl --select acl
Choose one of the available releases for acl:
 [0]  :  Cancel                                                    
 [1]  :  8.x-1.x-dev     -  2016-May-08  -  Development            
 [2]  :  8.x-1.0-alpha1  -  2015-Oct-19  -  Supported, Recommended
...

Expected behavior similar to views:

drush @$d8_site dl --select views
Choose one of the available releases for views:
 [0]  :  Cancel                                                   
 [1]  :  8.x-3.x-dev  -  2013-Oct-19  -  Development, Recommended
...

which causes drush dl views to return "There are no stable releases for project views".

rkquigley’s picture

rkquigley commented

I have been testing ACL (both alpha1 and -dev versions), via Forum Access, on my local instance and seems to be working just fine. I would like to be able to use it on our dev, and eventually prod servers by November, but concerned about the D7 migrate fail.
Since we built our site directly in D8, is this fail a moot point for us? Or will it be a potential vulnerability in some way I haven't found yet?

Thanks for all your work!

Rebecca Quigley

salvis’s picture

salvis
he/his
commented

I still haven't been able to find out what the migrate problem is, but since you won't do any migration, this will definitely not affect you.

Please open new issues for discussing things that are not directly related to the subject, so that they can be pursued and ultimately closed.

salvis’s picture

salvis
he/his
commented
Title: ACL - Alpha2 release » ACL for D8 — ALPHA1
Category: Plan » Task

@rwmanos: I understand your position, abut removing the supported tag from the alpha version makes it disappear from the front page, which is a no go.

@rkquigley: The migrate tests still don't pass — I don't know how to fix them, but the current #3081095: Project does not pass PHPUnit tests is a problem with the test, not with ACL.

However, please keep in mind that FA hasn't had its tests ported so far, which means it can't get out of ALPHA.

My instructions in #2 have been largely ignored, which is a pity. I will release ALPHA2 shortly, and rather than being able to continue here, I'll have to open a new thread. Feel free to continue the discussion here, but please stick to the instructions in the new thread.

salvis’s picture

salvis
he/his
commented
Status: Active » Fixed

#3083015: ACL for D8 — ALPHA2 is out and we'll continue there.

Thank you all for participating.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.