Refer:
https://api.drupal.org/api/drupal/core%21includes%21common.inc/function/...

CommentFileSizeAuthor
#5 interdiff_2-5.txt10.58 KBandriansyah
#5 2890244-5.patch605 bytesandriansyah
#2 achievements_deprecated_uses_replaced.patch11.39 KBbhawanac
format_date_replaced.patch1.04 KBbhawanac

Comments

bhawanac created an issue. See original summary.

bhawanac’s picture

bhawanac commented
StatusFileSize
new achievements_deprecated_uses_replaced.patch11.39 KB

Consider patch "achievements_deprecated_uses_replaced.patch".
Here i have replaced most of the deprecated uses from module.
All db_update, db_select, db_insert, format_date has been replaced as they are deprecated now.

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
Status: Needs review » Reviewed & tested by the community

Look good

grasmash’s picture

grasmash commented
Status: Reviewed & tested by the community » Needs work

This patch fails to apply against 8.x-1.x:

$ patch < achievements_deprecated_uses_replaced.patch
patching file achievements.api.php
Hunk #1 succeeded at 60 (offset -95 lines).
patching file achievements.install
Hunk #1 FAILED at 163.
Hunk #2 FAILED at 178.
2 out of 2 hunks FAILED -- saving rejects to file achievements.install.rej
patching file achievements.module
Hunk #1 FAILED at 234.
Hunk #2 FAILED at 409.
Hunk #3 FAILED at 417.
Hunk #4 FAILED at 429.
Hunk #5 FAILED at 470.
Hunk #6 FAILED at 538.
Hunk #7 FAILED at 568.
Hunk #8 FAILED at 605.
Hunk #9 FAILED at 714.
Hunk #10 FAILED at 757.
10 out of 10 hunks FAILED -- saving rejects to file achievements.module.rej
patching file achievements.pages.inc
Hunk #1 FAILED at 20.
Hunk #2 FAILED at 133.
Hunk #3 FAILED at 236.
Hunk #4 FAILED at 272.
4 out of 4 hunks FAILED -- saving rejects to file achievements.pages.inc.rej
andriansyah’s picture

andriansyah commented
Status: Needs work » Needs review
StatusFileSize
new 2890244-5.patch605 bytes
new interdiff_2-5.txt10.58 KB

I found some of the issues in patch #2 was already addressed in the 8.x-1.x branch. so I just add what I can found

grasmash’s picture

grasmash commented
Status: Needs review » Needs work

@andriansyah that line was addressed by a patch in #3089066.