Tnx for answering my previous question.

Now I would like to make an bug report: when adding nodes, using the drupal overlay, awarded achievements are not being displayed in the popup. When I post comments and get an achievement, it does work.

Is this 'works as designed', a known problem or ..?
If you need more information, please let me know. I haven't made any core hacks or module hacks.

Thanks agian :)

Comments

morbus iff’s picture

You've got the overlay up, great.

You submit the overlay, great.

An achievement popup doesn't show.

Does the popup show on THE NEXT page load?
Once the overlay is gone, if you just refresh the
page, does it show? (It should.)

morbus iff’s picture

I can confirm this. No idea yet on how to fix it though.

Normally, when you submit a node (without the overlay), you get redirected to your submitted node after you click "Submit", and you'd see the achievement popup (which shows on the first page the achiever accesses after earning it). With the overlay, however, you don't leave whatever page you're looking at, and I suspect the overlay silently discards/hides/whatever the "redirect to submitted node" functionality which, in turn, prevents you from seeing the achievement popup.

morbus iff’s picture

Status: Active » Fixed

This has been fixed.

diff --git a/achievements.module b/achievements.module
index 43a6d98..b9344b5 100644
--- a/achievements.module
+++ b/achievements.module
@@ -661,7 +661,9 @@ function achievements_user_delete($account) {
  * Implements hook_page_alter().
  */
 function achievements_page_alter(&$page) {
-  if (achievements_user_is_achiever()) {
+  // Achievement popups won't show if the overlay is active, so we'll defer until it isn't.
+  // See XXXX://drupal.stackexchange.com/questions/35382/hide-module-when-path-is-overlay.
+  if (achievements_user_is_achiever() && !(module_exists('overlay') && path_is_admin($_GET['q']))) {

Your question at StackExchange provided the answer: http://drupal.stackexchange.com/questions/35382/hide-module-when-path-is....

mhmhartman’s picture

thanks a lot mate, you're 1337 ;)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.