Both access checking and the logic to determine if someone has already unlocked an achievement return NULL.
| Comment | File | Size | Author |
|---|---|---|---|
| achievement-unlocked-already.patch | 571 bytes | marcingy |
Both access checking and the logic to determine if someone has already unlocked an achievement return NULL.
| Comment | File | Size | Author |
|---|---|---|---|
| achievement-unlocked-already.patch | 571 bytes | marcingy |
Comments
Comment #1
marcingy commentedComment #2
torgospizzaI think this approach makes sense. We should return something in either case.
I wonder if we'll need to change this bit further down in the function:
Since the return values here are mixed. Instead of NULL perhaps an empty array, or keeping things consistent from access control above and make it a FALSE instead. Thoughts?