Problem/Motivation

Getting the following errors/warnings.

FILE: /a11y_form_helpers/a11y_form_helpers.module
---------------------------------------------------------------------------
  10 | WARNING | [x] Unused use statement
  12 | WARNING | [x] Unused use statement
  15 | WARNING | [x] Unused use statement
 184 | WARNING | [ ] Empty return statement not required here
---------------------------------------------------------------------------

FILE: /a11y_form_helpers/README.txt
---------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------
 12 | WARNING | Line exceeds 80 characters; contains 142 characters
 24 | WARNING | Line exceeds 80 characters; contains 119 characters
---------------------------------------------------------------------------


FILE: /a11y_form_helpers/src/A11yFormHelpersRenderElement.php
---------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------
 28 | ERROR | The array declaration extends to column 81 (the limit is 80). The array content should be split up over multiple lines
----------------------------------------------------------------------------


FILE: /a11y_form_helpers/src/AutocompleteAttributeManager.php
----------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------
 15 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
----------------------------------------------------------------------------

Steps to reproduce

Run the following command

phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml a11y_form_helpers

Proposed resolution

The above errors/warnings need to be fixed.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

omkar_yewale created an issue. See original summary.

omkar_yewale’s picture

Assigned: omkar_yewale » Unassigned
Status: Needs work » Needs review

!1 MR created, Please review.

Rassoni’s picture

Reviewed MR and MR tested locally. PHPCS issues are fixed.

Tess Bakker made their first commit to this issue’s fork.

  • Tess Bakker committed 7850ebf2 on 2.0.x
    Issue #3353155 by omkar_yewale, Tess Bakker: Fix the issues reported by...
Tess Bakker’s picture

Status: Needs review » Fixed

Thanks for the fixes.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.