Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Getting the following errors/warnings.
FILE: /a11y_form_helpers/a11y_form_helpers.module
---------------------------------------------------------------------------
10 | WARNING | [x] Unused use statement
12 | WARNING | [x] Unused use statement
15 | WARNING | [x] Unused use statement
184 | WARNING | [ ] Empty return statement not required here
---------------------------------------------------------------------------
FILE: /a11y_form_helpers/README.txt
---------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------
12 | WARNING | Line exceeds 80 characters; contains 142 characters
24 | WARNING | Line exceeds 80 characters; contains 119 characters
---------------------------------------------------------------------------
FILE: /a11y_form_helpers/src/A11yFormHelpersRenderElement.php
---------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------
28 | ERROR | The array declaration extends to column 81 (the limit is 80). The array content should be split up over multiple lines
----------------------------------------------------------------------------
FILE: /a11y_form_helpers/src/AutocompleteAttributeManager.php
----------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------
15 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
----------------------------------------------------------------------------
Steps to reproduce
Run the following command
phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml a11y_form_helpers
Proposed resolution
The above errors/warnings need to be fixed.
Comment | File | Size | Author |
---|---|---|---|
#4 | Screenshot 2023-04-10 at 3.05.09 PM.png | 763 KB | Rassoni |
Issue fork a11y_form_helpers-3353155
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
omkar_yewale CreditAttribution: omkar_yewale as a volunteer and at Srijan | A Material+ Company for Drupal Association commented!1 MR created, Please review.
Comment #4
RassoniReviewed MR and MR tested locally. PHPCS issues are fixed.
Comment #7
Tess BakkerThanks for the fixes.