Problem/Motivation

Library is not tested.

Steps to reproduce

Proposed resolution

Write all tests necessary to have maximum coverage.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork a11y_autocomplete-3230678

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nod_ created an issue. See original summary.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented

We should test at least all the supported options and public api form #3217881: Reduce public API surface

nod_ opened merge request !4

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented

adding some tests to help with #3229110: use dataset instead of getattribute

  • nod_ committed 70ed4a5 on 1.0.x 
    Issue #3230678 by nod_: Write tests for options parsing

nod_ opened merge request !8

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented
Status: Active » Needs review

use same libraries as @drupal/once for testing

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented

Updated the gitlabci file to be in sync with the once package. Tests are running correctly :)

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented

code coverage is currently at 74.51% overall

to get code coverage run yarn test --coverage (or yarn web-test-runner --coverage) and open displayed html file to see details.

  • nod_ committed f7ab3f1 on 1.0.x 
    Issue #3230678 by nod_: Write tests
nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented

Merging what i have so far to unblock other things

nod_ opened merge request !10

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented

86.55% coverage

  • nod_ committed 4b65edd on 1.0.x 
    Issue #3230678 by nod_: Write tests
nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented

88.26% most of it is covered.

There are issues with de destroy method and the value splitting when a list is used (a lot of things happen on the drupal backend usually that we don't have access to here).

nod_ opened merge request !13

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented

89.3% with latest code mostly missing is the initialization for the aria described by feature and the various class adding/removing that the shim depends on.

good enough for now.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented
Status: Needs review » Reviewed & tested by the community

  • nod_ committed 05a98b6 on 1.0.x 
    Issue #3230678 by nod_: Write tests
nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.