Hi, mickaelperrin.

How about replacing patch functionality via service altering to change $response and make it as TrustedRedirectResponse.
As I see the last alterable point is RedirectResponseSubscriber::checkRedirectUrl
Below is patch with that idea.
What do you think?

CommentFileSizeAuthor
#2 replace-patch-via-service-altering-2854032-2.patch1.89 KBvlad.dancer
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vlad.dancer created an issue. See original summary.

vlad.dancer’s picture

vlad.dancer
Primary language Ukrainian
Location Kyiv
CreditAttribution: vlad.dancer at Drupalway for Foxylearning commented
Status: Active » Needs review
FileSize
replace-patch-via-service-altering-2854032-2.patch1.89 KB
vlad.dancer’s picture

vlad.dancer
Primary language Ukrainian
Location Kyiv
CreditAttribution: vlad.dancer at Drupalway for Foxylearning commented

Oh. BTW, forgot to check for 'ngrok' in url before transforming $response to the TrustedRedirectResponse

lolandese’s picture

lolandese CreditAttribution: lolandese commented
Status: Needs review » Reviewed & tested by the community

The patch makes indeed the module work as advertised without the need of the included patch at misc/UrlHelper.patch that alters core. To test, I got the trusted host error message when going e.g. to the user login page at /user. After applying the patch from #2, all works fine.

BTW I included a link to the sandbox in the documentation at Set up a local development Drupal site on the latest Ubuntu LTS version | Develop guide on Drupal.org.

Can the sandbox be turned into a full project? I think there are a substantial amount of people using it.

Thomas Cys’s picture

Thomas Cys
Primary language Dutch
CreditAttribution: Thomas Cys as a volunteer commented

+1 on turning this sandbox into a full project!

Marko B’s picture

Marko B CreditAttribution: Marko B commented

Seems this is not going anywhere, as 2 years after this patch is still not applied and project is in sandbox. I made a proper project here with patch applied https://www.drupal.org/project/ngrok_drupal as I need it in few projects and want to be able to use it straight away. Hope maintainer one day updates this, until then I will use this clone of mine :)

lolandese’s picture

lolandese CreditAttribution: lolandese commented

Cool. Can you copy-paste the project page content as well?
https://www.drupal.org/sandbox/mickaelperrin/2842335

lolandese’s picture

lolandese CreditAttribution: lolandese commented
Related issues: +#2842353: [D8] ngrok

There is a project application for this module that was actually approved. See related issue.

A pity it has not been converted into a full project as that is usually the intention of getting through this approval process (nowadays only needed to have security coverage).

Marko B’s picture

Marko B CreditAttribution: Marko B commented

I am not sure how to handle this, don't want to look like stealing a project, but maybe give it some time, if nothing happens I can make a full proper description and all. Not sure how long is the process if we want to try and change maintainer of original project if current one is not interested and 2 years period of not doing anything should be long enough?

lolandese’s picture

lolandese CreditAttribution: lolandese commented

Easiest is to drop him a note. If no answer is received, giving credit with a link to the user profile on the newly opened project page should be sufficient.

Considering this is a sandbox, the procedure described at Dealing with unsupported (abandoned) projects seems to be overkill.

mickaelperrin’s picture

mickaelperrin CreditAttribution: mickaelperrin as a volunteer commented

@everyone, it looks like I have missed a *lot* of activity here !!! Sorry for that.

Feel free to fork and maintain this project. I would be happy to see it has a second life and could be useful for others!

Marko B’s picture

Marko B CreditAttribution: Marko B commented

Thank you on responding :)