As noted by berdir on #2932371-13: Create a trait, or add methods to EntityForm, for logging and messages for entity add/update, we should be passing untranslated messages and args (not messages already passed through t()) into Messenger/drupal_set_message/Logger. This needs to be fixed in our entity forms.

Comments

jhodgdon created an issue. See original summary.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Title: Should pass untranslated messages into logging/messaging » Should pass untranslated messages into logging

Sorry, looked at code closer... This is only true for Logger messages. drupal_set_message() and Messenger take a translated message (output of t()).

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

Also we need to make sure that we are always putting the literal strings into t() and Logger calls, not $variables.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Active » Fixed
FileSize
2933920.patch2.08 KB

This was quick/easy/obvious so I just committed the patch. Will update the core issue shortly.

  • jhodgdon committed 3d86dd3 on 8.x-2.x 
    Issue #2933920 by jhodgdon: Should pass untranslated messages into...
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Active » Fixed

Status didn't take. ?!? I hate it when that happens.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.