This fixes a bug in the implementation (a left over `$node_type`) and switches the hooks to their entity-qualified counterparts.

CommentFileSizeAuthor
#7 fix_implementation-2371737-5.patch4 KBlendude
#7 interdiff-9323375-2-5.txt2.24 KBlendude
#6 fix_implementation-2371737-4.patch4 KBt0xicCode
#2 fix_implementation-2371737-1.patch3.56 KBt0xicCode
#1 fix_implementation-2371737-1.patch3.6 KBt0xicCode

Comments

t0xicCode’s picture

t0xicCode commented
Status: Active » Needs review
StatusFileSize
new fix_implementation-2371737-1.patch3.6 KB
t0xicCode’s picture

t0xicCode commented
StatusFileSize
new fix_implementation-2371737-1.patch3.56 KB

Oops, this should have been -2.patch.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Needs review » Needs work

The delete implementation throws an error.

Notice: Array to string conversion in pathauto_path_delete_all()

PDOException: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ' 'Array' OR source LIKE 'Array/%'' at line 1

Other changes look good. It could use a bit of cleaning up, thanks for that.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Needs work » Needs review
StatusFileSize
new fix_implementation-2371737-4.patch.txt4 KB

Something like this seems to work.

Added some more coding standard cleaning and a fix to the dependencies in .info

t0xicCode’s picture

t0xicCode commented
Status: Needs review » Reviewed & tested by the community

Thanks @Lendude. I had it seems I had modified the patch after I submitted it here. In any case, I can RTBC this and would love to see it added (and the module released).

t0xicCode’s picture

t0xicCode commented
StatusFileSize
new fix_implementation-2371737-4.patch4 KB

Didn't mean to delete this (today is not my day)...

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
StatusFileSize
new interdiff-9323375-2-5.txt2.24 KB
new fix_implementation-2371737-5.patch4 KB

Hehe, no worries.

The patch in #4 had some whitespace errors, fixed those and made an interdiff against your original patch in #2 (just cause I gotta get used to making those :-)

Will push those and will see what I can do about getting this released. Thanks for taking a look at it!

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Reviewed & tested by the community » Fixed

Pushed to sandbox.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Fixed » Closed (fixed)

And now with the right status to actually close it.....

t0xicCode’s picture

t0xicCode commented

Awesome! Any chance that you could promote the project to a full project?