While you're on it please look at my list

+++ b/core/modules/project_browser/js/project_browser_categories_widget.jsundefined
@@ -0,0 +1,11 @@
+(function ($) {
+  $('#edit-categories').multiselect({
+    noneSelectedText: '" . t('Choose') . "...',

If I'm not mistaken there is a new rule to add "strict" in every core js file. Just look at other js files.

+++ b/core/modules/project_browser/js/project_browser_more_link.jsundefined
@@ -0,0 +1,32 @@
+(function ($) {
+  $(document).ready(function() {
+    /**
+     * The project descriptions are by default trimmed to a certain height. When the user

Shouldn't we use drupal behaviours in here?

+++ b/core/modules/project_browser/project_browser.admin.incundefined
@@ -0,0 +1,36 @@
+
+// ======================================
+// Administration Page:
+// ======================================

Remove this we don't do this in core.

+++ b/core/modules/project_browser/project_browser.incundefined
@@ -0,0 +1,993 @@
+<?php
+/**

Add a newline after "<?php"

+++ b/core/modules/project_browser/project_browser.incundefined
@@ -0,0 +1,993 @@
+// Include the classes from the 'update' module

This comment isn't needed and is different from normal core behavior. Let's remove it

+++ b/core/modules/project_browser/project_browser.incundefined
@@ -0,0 +1,993 @@
+ * no real processing is done, we just redirect to the install/select_versions page

Exceeds 80 chars

+++ b/core/modules/project_browser/project_browser.incundefined
@@ -0,0 +1,993 @@
+ * Builds the filters form

Yeah we need "." on the end of these sentences like said before

+++ b/core/modules/project_browser/project_browser.incundefined
@@ -0,0 +1,993 @@
+      // Set the direction of the sort link to the opposite of what it currently is

Exceeds 80 chars

+++ b/core/modules/project_browser/project_browser.incundefined
@@ -0,0 +1,993 @@
+ *   (Optional) Set this to TRUE if you want to get all of the supported sort methods. Defaults to FALSE

Exceeds 80 chars

+++ b/core/modules/project_browser/project_browser.incundefined
@@ -0,0 +1,993 @@
+        // Create a new key so that there are no duplicate categories from different sites

Exceeds 80 chars

+++ b/core/modules/project_browser/project_browser.incundefined
@@ -0,0 +1,993 @@
+// ======================================
+// Server Related Functions:

Remove this block. Not a core pattern

+++ b/core/modules/project_browser/project_browser.incundefined
@@ -0,0 +1,993 @@
+ *   'text' => 'views', // The text that was entered as the search query, or '' if none
+ *   'categories' => array() // The categories that were selected, if any
+ *   'type' => 'module', // The type of project being searched
+ *   'page' => 3, // The zero-based page number

Thie is hard to read. Is it possible to format this a bit better?

+++ b/core/modules/project_browser/project_browser.incundefined
@@ -0,0 +1,993 @@
+ *   Returns an associative array of servers, populated from the project_browser_servers variable,

Exceeds 80 chars

+++ b/core/modules/project_browser/project_browser.incundefined
@@ -0,0 +1,993 @@
+// ======================================
+// Batch Operations:

Again: I would remove this.

+++ b/core/modules/project_browser/project_browser.incundefined
@@ -0,0 +1,993 @@
+ * Helper function to download a project. This code is mostly copied and pasted from
+ * modules/update/update.manager.inc

Don't use "Helper function". Just start with a 3th person verb in your short summary. Should fit on one line! (less than 80 chars)

+++ b/core/modules/project_browser/project_browser.incundefined
@@ -0,0 +1,993 @@
+    // Add this to the session variable and remove it from the install_queue variable

Exceeds 80 chars

+++ b/core/modules/project_browser/project_browser.incundefined
@@ -0,0 +1,993 @@
+ * If there were any errors, they are reported here with drupal_set_message(). The
+ * user is then redirected to the select versions page if there were errors, the

Exceeds 80 chars

+++ b/core/modules/project_browser/project_browser.moduleundefined
@@ -0,0 +1,485 @@
+// ======================================
+// Theme:

Let's remove this ;)

+++ b/core/modules/project_browser/project_browser.moduleundefined
@@ -0,0 +1,485 @@
+ * Add some variables for the project browser block theme

AddS

There are more errors but with my comments you should be able to fix them all. If you're unsure, read node/1354 on drupal.org

Comments

Anonymous’s picture

Status: Active » Needs review

I've gone through the list and changed the things you mentioned. Can you pull the latest code and check it?

aspilicious’s picture

Some thoughts while going through the files:

1)

// ======================================
// Administration Page:
// ======================================

Remove these kinda comments. And move the .admin.inc files outside of the theme folder.

2)

Tests classes should be namespaced, see tests in other core modules (they all live in the "lib" folder).

==> files[] = project_browser.test
That isn't supported anymore. We removed the registry in drupal 8. The test will never run ;)

3)
In "function project_browser_installation_page($op) {" you do "drupal_add_css(drupal_get_path('module', 'project_browser') . '/css/project_browser.css', array('preprocess' => FALSE));"

Create a hook_library for your module and call it here with drupal_add_library. Much much better.

4)
Still some doc issues left. I advise to read this documentation about admin forms: http://drupal.org/node/1354#forms
In general it's good to read through this.

5)
* Get a task list to the sidebar area when installing projects.

Should be "Gets". Just read every line of documentation after reading node/1354. Once you have read that page you can fix your own issues before I find them ;)

6)
You should type hint your parameters. Look at the "Doxygen directives - general notes" section on node/1354.
For example if yo parameter $some_value is an array it should be

@param array $some_value

7)
Css should be splitted into a base.css theme.css and admin.css
Base.css should contain all the styling to make the browser work in the spark theme.
(so just plain positioning stuff and absic theming)

All the other added fancyness should go into theme.css

And last but not least we have admin.css that is all the css needed to view the setting page and the project browser it self. As this is a backend feature this probably all is yourmodule.admin.css

Doing this allows drupal admin themes to easy remove all the admin.css and overwrite it with their own version.

Anonymous’s picture

Okay, I've hit each of those items now. Can you take another look and see if there is anything else I am missing?

Anonymous’s picture

I just got done changing a few more comment issues. It is ready for review now.

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

MUCH better. I don't think you need to declare an empty dependencies array in hook_library_info if there are no dependencies. But besides of that this looks great.

Time to roll another patch for the issue queue. This time code reviewers can jump in :)

Anonymous’s picture

Status: Reviewed & tested by the community » Closed (fixed)

Thanks for the reviews, I'm going to mark this as closed (I removed the dependencies and other empty arrays) and submit another patch on the issue queue.