Part of #1995272: [Meta] Refactor module CSS files inline with our CSS standards

#1912516: Markup for menus (Dream Markup)
#1899236: Add new Splitbutton render element to eventually replace Dropbutton (uses class="menu")

CommentFileSizeAuthor
#1 component-style-menu-class-1.patch848 bytesechoz
component-style-menu-class.patch2.38 KBechoz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

echoz’s picture

echoz CreditAttribution: echoz commented
Title: Refactor menu with new component-style selectors » Rename menu css classes with new component style naming
Issue tags: -Needs issue summary update
FileSize
component-style-menu-class-1.patch848 bytes

Re-roll.
Beginning the process, so far just the classes renamed in the css file. Todo: locate where html is generated and edit/add new class names.

echoz’s picture

echoz CreditAttribution: echoz commented
Issue summary: View changes

Moving text to #1

echoz’s picture

echoz CreditAttribution: echoz commented
Title: Rename menu css classes with new component style naming » Refactor menu with new component-style selectors
echoz’s picture

echoz CreditAttribution: echoz commented
Issue summary: View changes

Updated issue summary.

echoz’s picture

echoz CreditAttribution: echoz commented
Issue tags: +Needs issue summary update

tagging

ry5n’s picture

ry5n CreditAttribution: ry5n commented
Title: Rename menu css classes with new component style naming » Refactor menu with new component-style selectors
Issue tags: +Needs issue summary update

We’ll need to think about what types of menus we have. There are a number of different patterns in core:
- Toolbar navigation (custom)
- Generic top navigation (responsive?)
- Generic/sidebar navigation (multi-level)
- Nav with icons + captions (e.g. admin/ and admin/config)
- Dropdown menus (e.g. autocomplete, dropbutton)

These may or may not be separate components, for example (speculative):
- .toolbar
- .main-nav
- .nav
- .nav--caption (?)
- .menu (application-style menu, often dropdown/popup)

We may or may not want to go with a list-less nav (see #1912516: Markup for menus).

ry5n’s picture

ry5n CreditAttribution: ry5n commented
Issue summary: View changes

Added related issues

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin commented

I've gone through various styleguides and cataloged all the different names. Not much consensus. https://docs.google.com/spreadsheet/ccc?key=0AvR7gnIrX0ckdDgzNDI0blZVSnF...

menu, menu__item
side-nav
section_navigation
nav-list
menu-container, menu
navigation, active
aui-nav, aui-nav-heading
JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin commented
Title: Refactor menu with new component-style selectors » Refactor nested side menus with new component-style selectors

I want to be clear that we are just trying to refactor the nested menus that usually appear in a sidebar. There are other types of menus in drupal, but those are different components.

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin commented
Issue summary: View changes

Added note that #1912516: Markup for menus belongs to Dream Markup

mitokens’s picture

mitokens CreditAttribution: mitokens as a volunteer commented
Issue summary: View changes
Parent issue: » #1995272: [Meta] Refactor module CSS files inline with our CSS standards
Related issues: +#1912516: Markup for menus, +#1899236: Add new Splitbutton render element to eventually replace Dropbutton