Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.We discussed on a call that cache system isn't a good plugins use case at this time, and image effects were only implemented half way (they were not converted to classes), so both ended up not being helpful for understanding the system. This reverts them. Instead, I'll open a separate issue for converting the image toolkit system. Since we only have 1 toolkit (GD) in core, we can convert it all the way without adding much patch bloat.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | plugins-revert-image-and-cache.patch | 10.05 KB | effulgentsia |
| #1 | plugins-revert-image-and-cache.patch | 9.77 KB | effulgentsia |
Comments
Comment #1
effulgentsia CreditAttribution: effulgentsia commentedComment #2
sunHm. I somewhat agree on cache, but not necessarily on image effects. The implementation code for image effects showed how a typical info hook pattern can be replaced with new plugins. What's the reason for reverting them?
Comment #3
neclimdulDoesn't revert the removal of cache_get_backends().
Comment #4
effulgentsia CreditAttribution: effulgentsia commentedAh, I based #1 on #1497366-96: Introduce Plugin System to Core which had that removed already. I figured out how to diff against a remote, so this one should be good. Slowly, I'm climbing the git ladder.
Comment #5
neclimdulI tend to agree that image effects are a fairly good fit. They should be converted to PSR-0 though to /really/ fit the implement class requirement we technically have. So if removing them and following up with a full conversion gets us closer to committing (which is what I was lead to believe) I'm ok with it.
Comment #6
neclimdulI'm going to go ahead and mark this postponed on #1664844: Convert image toolkits into plugins. Its basically what we decided to do and what goes in with the initial patch isn't so important as getting the patch in. Postponed though because I want something other than tests in the sandbox so while this is straight forward and ready, I don't want to push it until toolkits are there to replace it.
Comment #7
neclimdulFixed. Pushed plugins-next-cache and plugins-next-image-effects with the reverted changes if someone wants to work on them.