Original messages from valthebald, posted in the full project access application queue #1073492: Meta tag simple
Posted by valthebald on March 21, 2011 at 1:55pm
please check existing module metatags_quick
Wanna join efforts?

Posted by valthebald on March 23, 2011 at 3:18pm
Hi,
I have downloaded and reviewed your code. Several conclusions/thoughts:
1. Grouping of meta fields to one vertical tab looks nice. In most (if not in all) cases people would want the whole bandle of tags, so it's logical to place them together.
2. API that you have chosen (node_* hooks) suits only for nodes, while entity API used in metatags_quick works with all entities. Also, I've got SQL exceptions when I tried to enable meta tags for one of existing content types. So I think storage engine should be based on fields, not on single table.
3. I suggest to think how it's possible to combine vertical tabs with fields of type meta.

What do you think?

Comments

jn2’s picture

jn2 commented

Finding a way to include the meta tags fields in the tab is definitely worth pursuing.

First, though, I want to resolve the SQL exception issue you discovered. There are people using this module already, and if there's a problem, I want to fix it.

Can you be specific:
1. Which existing content type gave the exceptions?
2. Exactly how did it show up?
3. What database/server are you using?

I'm going to do some testing on my own, but it would really help if I had a better idea where to look. I have this enabled on my site with both default and custom content types and have never had a problem.

valthebald’s picture

valthebald
Location Sofia
commented

This is a message I get:

PDOException: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'module' in 'field list': UPDATE {node_type} SET type=:db_update_placeholder_0, name=:db_update_placeholder_1, base=:db_update_placeholder_2, has_title=:db_update_placeholder_3, title_label=:db_update_placeholder_4, description=:db_update_placeholder_5, help=:db_update_placeholder_6, custom=:db_update_placeholder_7, modified=:db_update_placeholder_8, locked=:db_update_placeholder_9, disabled=:db_update_placeholder_10, module=:db_update_placeholder_11 WHERE (type = :db_condition_placeholder_0) ; Array ( [:db_update_placeholder_0] => page [:db_update_placeholder_1] => Basic page [:db_update_placeholder_2] => node_content [:db_update_placeholder_3] => 1 [:db_update_placeholder_4] => Title [:db_update_placeholder_5] => Use basic pages for your static content, such as an 'About us' page. [:db_update_placeholder_6] => [:db_update_placeholder_7] => 1 [:db_update_placeholder_8] => 1 [:db_update_placeholder_9] => 0 [:db_update_placeholder_10] => 0 [:db_update_placeholder_11] => node [:db_condition_placeholder_0] => page ) in node_type_save() (line 517 of /home/valeryl/work/zeepzap/modules/node/node.module).

jn2’s picture

jn2 commented

I just ran through Article, Basic, Book, Blog, and Forum with no problems. Looks like this was the Basic page.

Did you get the message simply by enabling the module?

Maybe it's conflicting with some other module you have enabled. I can't duplicate, at least not so far.

I'm trying some other things.

jn2’s picture

jn2 commented

I tried everything I could think of and could not reproduce your error. I enabled your module, 'Meta tags quick', added some tags, and even tried enabling Zeepzap, since it's in the path in your error message. Tried it through Windows and through Ubuntu (but all on MySQL). All worked fine.

One person getting an error message is no reason to reject code, although I know that is not your only reason to question the use of the node API. An earlier version of 'Meta tags quick' threw error messages on my machine, although the most recent version doesn't seem to do that.

It really doesn't matter at this point, anyway. I'm involved in another Drupal project that's taking all my time right now, so I won't have time to look at this for awhile. Thanks for offering to work together.

valthebald’s picture

valthebald
Location Sofia
commented
Title: Discussion about collaboration: 'Meta tags quick' and 'Meta tags simple" » Discussion about collaboration: 'Meta tags quick' and 'Meta tag simple'

Please don't get me wrong - I didn't suggest to reject your code, just digged into it to find what we can do together. Good luck anyway :)

jn2’s picture

jn2 commented
Status: Active » Postponed

Yes, I understand. I'm not necessarily closing the door on this collaboration, just postponing for now. We'll see what develops.

BTW, I agree that making meta tags available to all entities rather than just nodes is much better.

jn2’s picture

jn2 commented
Status: Postponed » Closed (won't fix)

About time this issue was closed.

@valthebald

Thanks for reaching out to me for collaboration. Obviously I've gone on to other things, and your module is doing quite well. Congratulations on that!

valthebald’s picture

valthebald
Location Sofia
commented

@jn2: thanks, and good luck to you in whatever you're currently at!