Code consistency and usability improvements

For cron.php, xmlrpc.php and index.php:
- "" -> '' where needed;

All modules use >em<string>/em<, only the aggregator-, blog-, filter-, and user.module uses >i<string>/i< to make italic text..
Attach patch fixes this..

We use >i<string>/i< inside the doxygen comments to, but I did not touch them.. Is there a reason why we do this? Or can Doxygen documentation generator handle >em<string>/em< also?

This patch superceeds the patch in post #1 where I used tabs instead of spaces :-$..
Number 2 and 3 still applies correctly and can be applied completely independent..

We should use a consistent form of drupal_set_message($message, $type) and form_set_error($name, $error) inside drupal. For example we use the following two ways of drupal_set_message:

drupal_set_message(t("error attaching file '%name': total file size exceeded", array('%name' => $file->filename)));

and

drupal_set_message(t("Error attaching file '%name': total file size exceeded", array('%name' => $file->filename)));

Notice the uppercase firstletter in the second drupal_set_message() example.. The story is exactly the same for the form_set_error()..

Attached patch fixes this behaviour and makes _all_ the drupal_set_message() and form_set_error() start with a capital letter everywhere..

Please review and apply...

A new patch for conf.php wich includes:
- improved helptext;
- "" -> '' where possible;
- used consistent code commenters like /**...*/ for the help texts;

Please review and apply...

Moshe Weitzman said:
instead of quotes around a filename, i'd prefer italics or code tag.

I'd really like to agree with Moshe! Please, if someone does not feel comfortable with this approach or has anything else against this, please reply.. A patch for such an approach is on it's way...

Allright! Attached patch makes watchdog(), drupal_set_message() and form_set_error() consistent in drupal.

- all messages of the mentioned functional start with a capital letter;
- all messages end with a '.' (dot);
- edited some texts to get rid of escaped single quotes;
- removed HTML-tags outside the translatable area's;
- added some more t()'s around forgotten strtr()-ed watchdog-messages inside locale.module;
- important sentences inside the strings are using the <em>important</em> tag, to give a more consistent look;
- using single quotes where this was possible, but tried to avoid escaping them.. Example:

- watchdog('error', t('Translation file "<em>%a</em>" couldn\'t be opened.', array('%a' => $file->name)));
+ watchdog('error', t("Translation file %filename couldn't be opened.", array('%filename' => "<em>$file->name</em>")));

When we use this form of writing consistently, the extraction script will become more and more handy and userfriendlyness because we can simply extract _all_ translatable strings/text from drupal without having extra '\'s..

If this patch hits core, I'll update the help-texts of all modules to keep this kind of unescaped help texts and strings consistent..

I think this would be a great improvement, code- and usability wise..

Please review attached patch and apply..

The first patch for the upload.module;
- using '' instead of "";
- using form_set_error() instead of drupal_set_message();
- commented out debug code;
- removed theme_attached_files() because it wasn't used; (Will come back later)
- made the headers of the tables use lowercase characters as we do in the rest of drupal;

Together with the patch in #13, drupal uses drupal_set_message(), form_set_error() and watchdog() in the same consistent way..

Please review and apply both patches...

This patch makes all headers inside the theme('table') look consistent. Now all headers start with a Capital letter.

In locale.inc we find another inconsistency. Attched one-line patch fixes this.

Setting to patch again, so everybody notice 'Patch Attached!'.

Patch also for the block.module.

Please review and apply..

Another inconsistent operation in the path.module.