Not valid (X)HTML [#994820]

Hi,

I wanted to validate my page by W3C validator and it claimed some mistakes in the code - they were reported a year ago but still the appear with the current version of this module:

end tag for "select" which is not finished - this appears just after the first selection list of my hierarchical select activitated exposed filter with which users can filter node with a hierachical taxonomy:


... selection-list...

<select name="marken[flat_select]" class="form-select flat-select" id="edit-marken-flat-select" ></select><div class="nojs"><input type="submit" name="op" id="edit-marken-nojs-update-button" value="Aktualisieren" class="form-submit update-button" />

The shown select-tag has no option-tags in it.

A second mistake appears in the code just before the select list: reference to non-existent ID "edit-marken". the code:

<div class="views-exposed-widget edit-marken">
<label for="edit-marken">
Marke </label>

It is the beginning of the exposed filter where hierarchical select is enabled. I also enabled labels for the several hierarchies and "marken" should be the label for the filter which is named "Marken" - but the hidden input field is named with id="edit-marken-hsid" and the select tag if id="id="edit-marken-hierarchical-select-selects-0"

Greez,
Tobias

Comments

Comment #1

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers commented 11 December 2010 at 11:01

Priority:	Normal	» Minor
Status:	Active	» Needs work

Could you maybe roll a patch? :)

Comment #2

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers commented 5 February 2011 at 15:26

Status:

Needs work

» Closed (won't fix)

Closing due to lack of response.

Comment #3

tobiberlin

German

Berlin, Germany

CreditAttribution: tobiberlin commented 9 February 2011 at 07:45

Status:

Closed (won't fix)

» Active

re-open it... sorry for not responding... I cannot as I am not familiar with rolling a patch - I even did not find out where to change these things.

Comment #4

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers commented 9 February 2011 at 07:50

Status:

Active

» Closed (cannot reproduce)

I can't even reproduce this. So, until you find the cause, I'm going to assume this is a problem with your installation only. Sorry.

Comment #5

mecmartini CreditAttribution: mecmartini commented 2 July 2011 at 11:22

Status:

Closed (cannot reproduce)

» Needs review

Hi,

I had the same problem with:

I wanted to validate my page by W3C validator and it claimed some mistakes in the code - they were reported a year ago but still the appear with the current version of this module:

end tag for "select" which is not finished - this appears just after the first selection list of my hierarchical select activitated exposed filter with which users can filter node with a hierachical taxonomy:

... selection-list...

<select name="marken[flat_select]" class="form-select flat-select" id="edit-marken-flat-select" ></select><div class="nojs"><input type="submit" name="op" id="edit-marken-nojs-update-button" value="Aktualisieren" class="form-submit update-button" />

The shown select-tag has no option-tags in it.

I found a cause into _hierarchical_select_process_render_flat_select function, so I did a fix changing the following code:

  $element = array(
      '#type' => 'select',
      '#multiple' => ($config['save_lineage'] || $config['dropbox']['status']),
      '#options' => $options,
      '#value' => array_keys($options),
      // Use a #theme callback to prevent the select from being wrapped in a
      // div. This simplifies the CSS and JS code.
      '#theme' => 'hierarchical_select_select',
      '#attributes' => array('class' => 'flat-select'),
    );

to:

  if (!empty($options)) {
  	$element = array(
      '#type' => 'select',
      '#multiple' => ($config['save_lineage'] || $config['dropbox']['status']),
      '#options' => $options,
      '#value' => array_keys($options),
      // Use a #theme callback to prevent the select from being wrapped in a
      // div. This simplifies the CSS and JS code.
      '#theme' => 'hierarchical_select_select',
      '#attributes' => array('class' => 'flat-select'),
    );
  }