'Number of elements must be positive in' and 'Invalid arguments passed in /usr/drupal/includes/database.inc' messages [#984908]

On a fresh install openning newly created gallery's sort page (http://mysite.com/node/21/sort) gives error message:

warning: array_fill() [function.array-fill]: Number of elements must be positive in /usr/drupal/includes/database.inc on line 253.
warning: implode() [function.implode]: Invalid arguments passed in /usr/drupal/includes/database.inc on line 253.
user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 1 query: SELECT n.nid,n.title,n.status,n.created,n.changed,f.filepath,ngi.weight FROM node n INNER JOIN node_revisions r ON r.vid = n.vid INNER JOIN content_type_node_gallery_image cck ON cck.nid = n.nid INNER JOIN files f ON f.fid = cck.field_node_gallery_image_fid INNER JOIN node_gallery_images ngi ON ngi.nid = n.nid WHERE n.nid IN () in /usr/drupal/sites/all/modules/node_gallery/node_gallery.inc on line 370.

Comment	File	Size	Author
#1	ng3-get-images-quickfix2.patch	916 bytes	scroogie

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

scroogie CreditAttribution: scroogie commented 30 November 2010 at 10:52

Assigned:	Unassigned	» scroogie
Status:	Active	» Needs review

File	Size
ng3-get-images-quickfix2.patch	916 bytes

Thanks for reporting. My fault. Here is the fix.

Comment #2

justintime CreditAttribution: justintime commented 30 November 2010 at 14:27

Status:

Needs review

» Fixed

Committed to dev for inclusion in alpha2. If you're a user running into this bug on alpha1, note you don't need to upgrade to dev, just add an image to the gallery and the sort page will work.

@scroogie, I modified your code a bit so that we return an empty array instead of NULL.

Comment #3

parasox CreditAttribution: parasox commented 30 November 2010 at 22:17

Was about to report the same (similar?) thing.. My error code is slightly different, so figured I should post it here.

Warning: array_fill() [<a href='function.array-fill'>function.array-fill</a>]: Number of elements must be positive in db_placeholders() (line 276 of /var/www/includes/database.inc).
Warning: implode() [<a href='function.implode'>function.implode</a>]: Invalid arguments passed in db_placeholders() (line 276 of /var/www/includes/database.inc).
User warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near &#039;)&#039; at line 1 query: SELECT n.nid,n.title,n.status,n.created,n.changed,f.filepath,ngi.weight FROM node n INNER JOIN node_revisions r ON r.vid = n.vid INNER JOIN content_type_node_gallery_image cck ON cck.nid = n.nid INNER JOIN files f ON f.fid = cck.field_node_gallery_image_fid INNER JOIN node_gallery_images ngi ON ngi.nid = n.nid WHERE n.nid IN () in _db_query() (line 141 of /var/www/includes/database.mysqli.inc).