Hello!! Awesome work, first of all...

Sidebar widht override option behind Advanced Layout Options don't work. Apparently do not override width and Sidebar width as percentage, showing two equal sidebars. Even when override value keep stored in advanced layout form in pixel and as percentage mode.

Thanks in advance.

Comments

JurriaanRoelofs’s picture

Assigned: Unassigned » JurriaanRoelofs
Status: Active » Fixed

thx for your issue. There is a mistake in sooper_tundra\features\sooper-layoutkit\layoutkit-theme-settings-css.inc

in this file you have to change all instances of sleft to side-first and sright to side-second, the content of the file will be as follows:

<?php
$layout_width_fixed = theme_get_setting('layout_width_fixed');
$layout_width_fluid = theme_get_setting('layout_width_fluid');
$layout_min_width = theme_get_setting('layout_min_width');
$layout_max_width = theme_get_setting('layout_max_width');
$sidebar_left_override = theme_get_setting('sidebar_left_override');
$center_column_override = theme_get_setting('center_column_override');
$sidebar_right_override = theme_get_setting('sidebar_right_override');

if (theme_get_setting('fixedfluid') == 'px') {
  $layout_width_fixed += 2; //to make sure inner layout width == layout_width_fixed even though it has 1px borders on side. This prevents conflict with column width override settings.
  $CSS .= ".sooper-mast { width: {$layout_width_fixed}px; }\n";
} else {
  $CSS .= ".sooper-mast { width: {$layout_width_fluid}%; }\n";
}
if ($layout_min_width) {
  $CSS .= "body .sooper-mast { min-width: {$layout_min_width}px; }\n";
} else {
$CSS .= "body .sooper-mast { min-width: 0; }\n";
}
if ($layout_max_width) {
  $CSS .= "body .sooper-mast { max-width: {$layout_max_width}px; }\n";
} else {
  $CSS .= "body .sooper-mast { max-width: none; }\n";
}
if (theme_get_setting('expand_admin')){
  $CSS .= "body.section-admin .sooper-mast,body.section-admin #footer { width:90%; }\n";
}

if ($sidebar_left_override){
  $CSS .= ".sidebar.side-first { width: {$sidebar_left_override}!important; }\n";
  $CSS .= "#main .sooper-mast { background-position: {$sidebar_left_override} 0!important; }\n";
}

if ($center_column_override){
  $CSS .= "#content { width: {$center_column_override}!important; }\n";
}

if ($sidebar_right_override){
  $CSS .= ".sidebar.side-second { width: {$sidebar_right_override}!important; }\n";
  //this will only work if you differentiate betwene px and % values. but it wont work with px values in a % layout? maybe add an override for the fauxcolumn position
  //$sidebar_right_faux = ;
  //$CSS .= "#main .wrapcolumns { background-position: {$sidebar_right_faux} 0!important; }\n";
}
JurriaanRoelofs’s picture

I have commited the fix to the dev release of Tundra. But I only have one CVS folder that contains both the D6 and D7 versions of the theme so I wouldn't recommend trying to install the dev version, I will release all the fixed Tundra D6 code in a new beta when the other issues are solved.

quiquedb’s picture

Thank you for your fast reply. Replacing those instances works perfect.

cheers!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.