Taxonomy menu seems suboptimal: taxonomy_menu($may_cache)

First:

  else {
    if (is_numeric(arg(3))) {

Why not just an elseif() ?

Second:

    if (is_numeric(arg(3))) {

Will hit in for ALL urls with a number on place 3, seems rather nasty to me. Why not check for more?

CommentFileSizeAuthor
#1 taxonomy_menu_more_precise541 byteschx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chx’s picture

chx CreditAttribution: chx commented
Status: Active » Needs review
FileSize
taxonomy_menu_more_precise541 bytes
Bèr Kessels’s picture

Bèr Kessels CreditAttribution: Bèr Kessels commented

Tested, but not benchmarked.
This should speed up things a little though.

But a -1 on this one, there is still an else and an if inside that, instead of an elseif

Bèr

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Status: Needs review » Fixed

Committed to HEAD.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)