I get the following errors after a fresh install of D7 Beta 3 & the latest commerce dev on the order & products page

Notice: Trying to get property of non-object in views_handler_area_text->render_textarea() (line 45 of /var/www/d7b3commerce/sites/all/modules/contrib/views/handlers/views_handler_area_text.inc).

It goes away after content is added for the view to pick up. Found a similar issue here: http://drupal.org/node/829310

CommentFileSizeAuthor
#7 976106-7.patch2.91 KBbendiy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

PieterDC’s picture

I've also noticed that one.

rszrama’s picture

Component: User experience » Views integration

I've noticed this, too... I think our default Views need to be re-exported to code to pick up some missing properties.

recrit’s picture

confirmed missing text format for empty text.
if you edit view for orders or products, the empty text format is not set. If you select a format (ex. plain text), then no errors.

rszrama’s picture

bendiy’s picture

I'm still getting this error after making those changes:

    * Strict warning: Declaration of commerce_product_handler_field_product::init() should be compatible with that of views_handler_field::init() in require_once() (line 12 of d7\sites\all\modules\commerce\modules\product\includes\views\handlers\commerce_product_handler_field_product.inc).
    * Strict warning: Declaration of views_handler_field_field::pre_render() should be compatible with that of views_handler_field::pre_render() in _registry_check_code() (line 2791 of d7\includes\bootstrap.inc).

Adding "&" to the $options variable in "commerce_product_handler_field_product.inc" line 13 works.

class commerce_product_handler_field_product extends views_handler_field {
  function init(&$view, &$options) {
    parent::init($view, $options);

    if (!empty($this->options['link_to_product'])) {

Same goes for "views_handler_field.inc" line 456.

  function pre_render(&$values) { }
bendiy’s picture

Status: Fixed » Needs work

I'm also getting these errors right after I clear View's Cache:

# Strict warning: Only variables should be passed by reference in commerce_product_reference_field_views_data_alter() (line 566 of d7\sites\all\modules\commerce\modules\product_reference\commerce_product_reference.module).
# Strict warning: Only variables should be passed by reference in commerce_line_item_field_views_data_alter() (line 1062 of d7\sites\all\modules\commerce\modules\line_item\commerce_line_item.module).
bendiy’s picture

Status: Needs work » Needs review
FileSize
2.91 KB

Attached is a patch to fix all the errors in #5 and #6 except for the "views_handler_field.inc" line 456. That's a Views issue. It appears to be fixed with this patch #974542: Strict warnings.

rszrama’s picture

Status: Needs review » Fixed

Thanks a lot! Committed. : )

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.