Notice: Undefined index: order [#967790]

I'm using this with Drupal 7 beta 2 and Views 7.x-3.x-dev. When trying to save settings, I get an error message saying:

Notice: Undefined index: order in draggableviews_plugin_style_draggabletable->validate() (line 83 of views/draggableviews_plugin_style_draggabletable.inc).

I did some looking around and it seems $this->view->get_items('sort', $this->display->id); doesn't return the sort order if it is set to the default (ASC). I created a patch that does a check for this index and if not, sets sort to ASC so that index is available for validation.

I hope this helps and thank you for your work with this module.

Comment	File	Size	Author
#7	draggableviews-order.patch	1.14 KB	smk-ka
#7
#3	repair_empty_default_sorting-967790-3.patch	1.21 KB	Itangalo
#3
	draggableviews_plugin_style_draggabletable.patch	1009 bytes	cocoloco

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

cocoloco CreditAttribution: cocoloco commented 10 November 2010 at 15:13

Status:

Active

» Needs review

Comment #2

cocoloco CreditAttribution: cocoloco commented 10 November 2010 at 15:14

Title:

Notice: Undefined index: order (patch available)

» Notice: Undefined index: order

Comment #3

Itangalo CreditAttribution: Itangalo commented 9 June 2011 at 12:47

File	Size
repair_empty_default_sorting-967790-3.patch	1.21 KB

Patch rerolled against latest dev, and also to work against the module root directory.

Strangely, I still had some issues after applying this patch. (They disappeared after resaving the sort criteria – don't know if that's because of the patch or because of the save. Sorry.)

Comment #4

Itangalo CreditAttribution: Itangalo commented 9 June 2011 at 12:54

No, sorry, that was me being silly. The patch should work fine.
If someone else can confirm, I'd say that this issue could be set to "reviewed and tested by the community".

Comment #5

rv0 CreditAttribution: rv0 commented 20 June 2011 at 10:50

had some issues with latest dev (patch didn't apply + even without patch, it gave me WSOD on some pages)

so I applied it manually to the previous dev is was using, and this seems to work fine.

Comment #6

stred CreditAttribution: stred commented 20 June 2011 at 22:32

same for me: the patch didn't apply but the code fixed this issue.

Comment #7

smk-ka CreditAttribution: smk-ka commented 22 June 2011 at 09:15

File	Size
draggableviews-order.patch	1.14 KB

Slightly simplified patch, without explicitly setting the value of 'order'.

Comment #8

carl.brown CreditAttribution: carl.brown commented 5 July 2011 at 09:36

I can confirm that the code in #7 gets rid of the notice on my install: D7.4, Views 7.x-3.0-rc1, DraggableViews 7.x-1.x-dev - however, I didn't try the patch file itself due to previous commenter's problems.
Oddly, I didn't get this notice on the first view I created with just one page display-type, but when I used exactly the same settings for a page display in another view which already had and entity content display type (from the EVA module), that's when the problems started. I'll have another play around at some point and update you if I find anything. Thanks for the patch!

Comment #9

steinmb CreditAttribution: steinmb commented 10 July 2011 at 12:56

The patch #7 applied cleanly. But I still get a list of warnings when saving a new sort order.

Notice: Undefined index: value0_316 in draggableviews_view_draggabletable_form_submit() (line 443 of /drupal/sites/all/modules/draggableviews/draggableviews.module)
.......

Dunno if these warning are related to this issue or not.