FireFox Issue, Was: Over-encoding of addresses with + [#956076]

I thought I had this all working but I upgraded drupal and when I went back to double check nothing is working. Here is what I have set up:

Drupal 6.19, Invisimail 6.1.2 and 6.1.x-dev

Turned off all filters in "filtered HTML" except for "Encode email addresses"

Settings 1:
place simple text "email@test.net" with no code
No Javascript: checked
Do not create links.: checked

Results 1 : Nothing changed

Settings 2:
place simple text "email@test.net" with no code
No Javascript: checked
Automatically create links from email addresses: checked

Results 2 :
Source code:

email@test.net.

Settings 3:
place simple text "email@test.net" with no code
USE Javascript: checked
Automatically create links from email addresses: checked

Results 3 :
Source code:

'+'frankagapito@'+'frontiernet.'+'net.'+''+''); //-->

email@test.net.

Settings 4:
place simple text "email@test.net" with no code
USE Javascript: checked
Do not create links.: checked

Results 4 :
Source code:

email@'+'test.'+'net

Nothing happens if I use mailto:email@test in the node

Anyone else having this issue?

Comments

Comment #1

coderintherye CreditAttribution: coderintherye commented 29 October 2010 at 07:14

For what it's worth, if you want to dig into the code you can edit line 192 and line 236 of invisimail.module file to remove the pluses.

Comment #2

lucascaro CreditAttribution: lucascaro commented 4 November 2010 at 14:25

I had the same problem. It ended up being a conflict with other filters. In my case, wysiwyg filter and pathologic needed to be first. then invisimal, then the rest of the filters.

Comment #3

spgd01 CreditAttribution: spgd01 commented 8 November 2010 at 19:21

I just installed a new 6.19 site with no modules except invisamail. Nothing is working. If I uncheck all filters and just use invisamail in full html I get the following still:

<script type="text/javascript"><!--
    document.write('<a href="&#109;&#97;&#105;&#108;&#116;&#111;&#58;'+'&#105;&#110;&#102;&#111;&#64;'+'&#115;&#97;&#113;&#114;&#110;&#111;&#46;'+'&#99;&#111;&#109;'+'">'+'&#105;&#110;&#102;&#111;&#64;'+'&#115;&#97;&#113;&#114;&#110;&#111;&#46;'+'&#99;&#111;&#109;'+'</a>');
    //-->
    </script><a href="mailto:info@saqrno.com">info@saqrno.com</a>

Something is wrong if the mailto link is outside the javascript.

Any Ideas?

Comment #4

savedario CreditAttribution: savedario commented 11 November 2010 at 16:28

I am having the same issue.
subscribe

Comment #5

Crell CreditAttribution: Crell commented 17 November 2010 at 22:44

Title:	Not working at all with 6.19	» Over-encoding of addresses with +
Category:	support	» bug
Status:	Active	» Fixed

Oh boy. The issue here, I think, is over-encoding of the address when using JS *without* turning things into links. That breaks. I've updated the code to only throw in extra + characters when doing both JS encoding and linking.

Comment #6

spgd01 CreditAttribution: spgd01 commented 18 November 2010 at 17:49

Title:

Over-encoding of addresses with +

» FireFox Issue, Was: Over-encoding of addresses with +

Still not working!

Edit: This may be a Firefox issue.

Firefox 3.6.12:

<p><span id="919301b5c518c9ff00d1a59ebc883be5"><a href="mailto:test@example.com">test@example.com</a></span>
            <script type="text/javascript"> <!--
        document.getElementById('919301b5c518c9ff00d1a59ebc883be5')
                .innerHTML = '<a href="&#109;&#97;&#105;&#108;&#116;&#111;&#58;'+'&#116;&#101;&#115;&#116;&#64;&#101;&#120;&#97;&#109;&#112;&#108;&#101;&#46;&#99;&#111;&#109;'+'">'+'&#116;&#101;&#115;&#116;&#64;&#101;&#120;&#97;&#109;&#112;&#108;&#101;&#46;&#99;&#111;&#109;' + '</a>';
 // --> </script></p>

IE:


<p><span id="919301b5c518c9ff00d1a59ebc883be5"></span>
            <script type="text/javascript" > <!--
        document.getElementById('919301b5c518c9ff00d1a59ebc883be5')
                .innerHTML = '<a href="&#109;&#97;&#105;&#108;&#116;&#111;&#58;'+'&#116;&#101;&#115;&#116;&#64;&#101;&#120;&#97;&#109;&#112;&#108;&#101;&#46;&#99;&#111;&#109;'+'">'+'&#116;&#101;&#115;&#116;&#64;&#101;&#120;&#97;&#109;&#112;&#108;&#101;&#46;&#99;&#111;&#109;' + '</a>';
 // --> </script></p>

Anyone else having problems with firefox?

Comment #7

spgd01 CreditAttribution: spgd01 commented 18 November 2010 at 19:10

Ok Found the answer

web developers tools were changing the java script link to a mail to link. So if you are having this problem turn off firebug and html validator and anything else for source development.

All is working as it should.

Crell, Thank you for your help and a great module.