Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Any chance of getting the http://drupal.org/project/dopl filter added to the site? It would save lots of typing.
Comments
Comment #1
Gerhard Killesreiter CreditAttribution: Gerhard Killesreiter commentedI am not neccessarily opposed to this but one would need to make sure that
1) The module works with drupal.org: A lot of modules are written in a way that works nicely on a small site but doesn't work on a big site like d.o.
2) The module is maintained and will be ported to D7.
Comment #2
WorldFallz CreditAttribution: WorldFallz commentedFor 1, testing with drupalorg_testing isn't going to stress test the module. I'm not sure how to test for that-- any ideas?
For 2, I'll try to contact the maintainer-- if the module isn't actively maintained I'm happy to take it over.
Comment #3
Gerhard Killesreiter CreditAttribution: Gerhard Killesreiter commentedfor 1) you'd need to review the code for such traps as non-optimized queries etc. Since it is a filter, we should also make sure it doesn't use preg_replace with /e. We could try it on a scratch site.
Before going ahead, I'd like to see some comments on whether this is considered good UI etc.
Comment #4
WorldFallz CreditAttribution: WorldFallz commentedSounds good-- i'll at least do a code review and see what I can see.
Comment #5
z.stolar CreditAttribution: z.stolar commentedI'm the maintainer of dopl. I'm quite happy dopl might find it's way into d.o., but I must admit I am not sure it's up to Killes's standards ;-)
As per the questions at #1:
1) The module uses a callback function for it's preg replacement. I'm quite sure it's not heavy on resources, but I can't certify it. I also use cache, so polling the server for project names will quickly be dealt with cache only. Here as well, I am sure there is more than one way to optimise the module - poll local directories, poll a repository...
2) The module has arrived a certain maturity and it works as expected, so I don't really maintain it. However, I still use it daily at http://drupal.org.il, for which it was written, and I track the issue queue. If you think there's a good chance for it to enter d.o., I'll can have it ported to D7 (@killes: is d.o. moving to D7 soon?)
I probably should port it anyway... :)
As for UI benefits - all I can say is that once you get used to it (and it's really easy to get used to), it becomes very handy, and improves the readability of Drupal related posts.
Comment #6
joachim CreditAttribution: joachim commented+1 to having this functionality on d.org.
I've just taken a quick look at the module code.
If preg_replace_callback() is a slower function to use, I reckon the same thing could be done with a regular preg_replace(). Could do with a bit of a code tidy up around all the $matches[x] which are hard to keep track of. Would need someone who knows more than me about caching to take a look to see if it's doing the best thing there.
Comment #7
Damien Tournoud CreditAttribution: Damien Tournoud commentedJust to clarify, what we don't want is exactly that: "preg_replace() with /e". preg_replace_callback() is perfectly ok.
Comment #8
shadcn CreditAttribution: shadcn commentedI ported the module to Drupal 7 : #1154664: Dopl - Drupal 7 Port. I think it would be a cool addition for d.o users and Drupal bloggers.
Comment #9
shadcn CreditAttribution: shadcn commentedBacking up what z.stolar said in #5,
http://www.youtube.com/watch?v=xx1-sPE8d1s&feature=youtu.be
Comment #10
killes@www.drop.org CreditAttribution: killes@www.drop.org commentedThat link is strange, it tells me that it contains content from UMG which isn't available in .de...
Did anybody actually check the code out?
Comment #11
shadcn CreditAttribution: shadcn commentedAh. might be the soundtrack. updated version : http://www.youtube.com/watch?v=xx1-sPE8d1s
(wish youtube had git commit and git push :P)
Comment #12
shadcn CreditAttribution: shadcn commentedComment #13
shadcn CreditAttribution: shadcn commentedI'd love to make this happen. It would help a lot in the Drupal forums and issue queues. How can I help to move this forward?
Comment #14
killes@www.drop.org CreditAttribution: killes@www.drop.org commentedYou need to apply and receive a dev site to test the module there.
http://drupal.org/node/1018084
Comment #15
killes@www.drop.org CreditAttribution: killes@www.drop.org commentedPostponing.
Comment #16
MixologicDrupal.org feature requests should go into drupal.org customizations.
Comment #17
Mixologic