Any chance of getting the http://drupal.org/project/dopl filter added to the site? It would save lots of typing.

Comments

Gerhard Killesreiter’s picture

I am not neccessarily opposed to this but one would need to make sure that

1) The module works with drupal.org: A lot of modules are written in a way that works nicely on a small site but doesn't work on a big site like d.o.

2) The module is maintained and will be ported to D7.

WorldFallz’s picture

For 1, testing with drupalorg_testing isn't going to stress test the module. I'm not sure how to test for that-- any ideas?

For 2, I'll try to contact the maintainer-- if the module isn't actively maintained I'm happy to take it over.

Gerhard Killesreiter’s picture

for 1) you'd need to review the code for such traps as non-optimized queries etc. Since it is a filter, we should also make sure it doesn't use preg_replace with /e. We could try it on a scratch site.

Before going ahead, I'd like to see some comments on whether this is considered good UI etc.

WorldFallz’s picture

Sounds good-- i'll at least do a code review and see what I can see.

z.stolar’s picture

I'm the maintainer of dopl. I'm quite happy dopl might find it's way into d.o., but I must admit I am not sure it's up to Killes's standards ;-)

As per the questions at #1:

1) The module uses a callback function for it's preg replacement. I'm quite sure it's not heavy on resources, but I can't certify it. I also use cache, so polling the server for project names will quickly be dealt with cache only. Here as well, I am sure there is more than one way to optimise the module - poll local directories, poll a repository...

2) The module has arrived a certain maturity and it works as expected, so I don't really maintain it. However, I still use it daily at http://drupal.org.il, for which it was written, and I track the issue queue. If you think there's a good chance for it to enter d.o., I'll can have it ported to D7 (@killes: is d.o. moving to D7 soon?)
I probably should port it anyway... :)

As for UI benefits - all I can say is that once you get used to it (and it's really easy to get used to), it becomes very handy, and improves the readability of Drupal related posts.

joachim’s picture

+1 to having this functionality on d.org.

I've just taken a quick look at the module code.

If preg_replace_callback() is a slower function to use, I reckon the same thing could be done with a regular preg_replace(). Could do with a bit of a code tidy up around all the $matches[x] which are hard to keep track of. Would need someone who knows more than me about caching to take a look to see if it's doing the best thing there.

Damien Tournoud’s picture

Since it is a filter, we should also make sure it doesn't use preg_replace with /e

Just to clarify, what we don't want is exactly that: "preg_replace() with /e". preg_replace_callback() is perfectly ok.

shadcn’s picture

I ported the module to Drupal 7 : #1154664: Dopl - Drupal 7 Port. I think it would be a cool addition for d.o users and Drupal bloggers.

shadcn’s picture

Backing up what z.stolar said in #5,

As for UI benefits - all I can say is that once you get used to it (and it's really easy to get used to), it becomes very handy, and improves the readability of Drupal related posts.

http://www.youtube.com/watch?v=xx1-sPE8d1s&feature=youtu.be

killes@www.drop.org’s picture

Status: Active » Needs work

That link is strange, it tells me that it contains content from UMG which isn't available in .de...

Did anybody actually check the code out?

shadcn’s picture

Ah. might be the soundtrack. updated version : http://www.youtube.com/watch?v=xx1-sPE8d1s

(wish youtube had git commit and git push :P)

shadcn’s picture

Status: Needs work » Needs review
shadcn’s picture

I'd love to make this happen. It would help a lot in the Drupal forums and issue queues. How can I help to move this forward?

killes@www.drop.org’s picture

You need to apply and receive a dev site to test the module there.

http://drupal.org/node/1018084

killes@www.drop.org’s picture

Status: Needs review » Postponed (maintainer needs more info)

Postponing.

Mixologic’s picture

Project: Drupal.org infrastructure » Drupal.org customizations
Version: » 7.x-3.x-dev
Component: Other » Code
Issue summary: View changes
Status: Postponed (maintainer needs more info) » Closed (fixed)

Drupal.org feature requests should go into drupal.org customizations.

Mixologic’s picture

Status: Closed (fixed) » Postponed