Problem/Motivation

Drupal.org does not react to the viewport size of the viewer, this means that, for example, the text size on issue queue pages is tiny. That is, the Bluecheese theme is not responsive nor adaptive.

Proposed resolution

Get a development sandbox #1435260: I want a drupal.org development site for making bluecheese adaptive

@lewisnyman intially outlined a way to proceed:

  1. Throw some mobile friendly meta tags in there
  2. Convert the grid system to % instead of pixels using the target / context equation. It's important that we leave the main page wrapper fixed at 960px during this period so we can verify the proportions match the pixel based layout.
  3. Remove any crazy set heights.
  4. Take off fixed 960px width off the main page wrapper.
  5. Add single Desktop first media query to switch to a single column layout.
  6. Bug fixing

Update

The layout for Drupal.org is very complex with a lot of elements being thrown around. A single media query trigger is being explored using Omega (#1438716: [Meta] Port bluecheese to Drupal 7) but will ultimately provide us with a bad mobile/tablet/etc experience. See Responsive Drupal.org - What we want in a framework

Remaining tasks

We have a development sandbox here: http://responsive-drupal.redesign.devdrupal.org/

  1. Merge 7.x-1.x into 7.x-2.x to get upstream changes.
  2. Change anything overriding drupalorg code, such as drupalorg-home.tpl.php and home.js into patches for drupalorg. Site-specific code overriding site-specific code is not maintainable.
  3. Change the template.php additions into patches for drupalorg or drupalorg_crosssite. No new PHP should be added to the theme unless absolutely necessary.
  4. #2228139: Improve line wrapping in tables should have a resolution on the 7.x-1.x branch.
  5. Anything else practical to make the diff between 7.x-1.x and 7.x-2.x smaller and more reviewable.

User interface changes

Hopefully we'll make Drupal.org responsive/adaptive.

Original report by [username]

It wound be great to have a more mobile friendly site. At least the project issue queue's does zoom if you double tip them. The font is toooo small to read. Would be really great if there is a mobile version or at least a version that works much better on small displays like the iphone.

Comments

hass’s picture

Ups, project issue queues are NOT zoomed if double tipped on iphone.

drumm’s picture

Project: » Bluecheese
Component: Everything Else » User interface
Issue tags: -drupal.org redesign

Mobile is 1.2% of our traffic and probably growing. Certainly worth doing if people have time/motivation to spend doing it, but for now Durpal.org is a primarily-computer site.

Gerhard Killesreiter’s picture

zooming works just fine on my android phone.

I am not sure which improvements people would want to see for a modern mobile version.

hass’s picture

If I double tip the comments here, nothing is zoomed on iOS 4.1. Would be great if the fixed width may be removed and the text becomes larger. Than we may not need to zoom.

beautifulmind’s picture

I'd love to use drupal.org on my mobile too.

Thank you.

Stephanie_42’s picture

I'd also love phone support

cweagans’s picture

I want to build the mobile version. It will involve building two more themes: one for smartphones like iPhone and Android devices, and one for dumbphones that don't have a real web browser.

I've put in a request for a development environment and, if granted, I will build this.

cweagans’s picture

Assigned: Unassigned » cweagans
jensimmons’s picture

Assigned: cweagans » Unassigned

+1

And I highly recommend redoing the current site's theme using media queries, and not creating a "mobile theme" or "mobile site".

http://www.alistapart.com/articles/responsive-web-design/

By using media queries, the CSS can be adjusted for phones and tablets, while keeping everything in one code base. A mobile theme can get quickly out of sync with the desktop site — where something new is added to the main site, but never gets support in the mobile theme, etc. Let's adjust the current theme, using the current design — not make a new one.

Here are some great examples of media queries in action:
http://mediaqueri.es/

drumm’s picture

frjo #1033538: I want access to bzr+ssh://drupal-redesign@util.drupal.org/ and cweagans #1045828: I want a drupal.org development site both have access to the mobile.redesign.devdrupal.org development site. Details on the system are at http://drupal.org/node/1018084. Please post a bzr diff here when ready for review.

frjo’s picture

FileSize
1.71 KB

I have put together a simple/crud iphone.css for Drupal.org/Bluecheese theme. While simple it makes drupal.org a lot nicer to use on an iPhone (and Android devices as well I believe.)

I have two simple goals for the iPhone (and all other mobile devices):

* Avoid the need to zoom in and scroll sideways, making the text readable directly.
* Make the navigation and the search function touch friendly with larger buttons/fields and more spacing.

After some testing and improvements I would very mush like to see a iphone.css added to d.o.

There is of course a lot more that can be done but this is a good start that demands little work.

It can be added with these lines of code in page.tpl.php.

<!-- Start iPhone stuff -->
<link rel="stylesheet" type="text/css" media="only screen and (max-device-width: 480px)" href="http://drupal.org/sites/all/themes/bluecheese/iphone.css" />
<meta name="viewport" content="width=device-width" />
<!-- End iPhone stuff -->
frjo’s picture

#11 Posted some screenshots in my blog here http://xdeb.org/node/1492

hass’s picture

I would not make this for the iphone only. Just name it mobile.css or smartphone.css or lowres.css or similar... As this depends only on screenresolution, this should have such a name. I would love to have better expierience with iphone... Let's get this in production :-)

drumm’s picture

Great, I've been using Drupal.org mobile a bit on my old Android phone. The biggest annoyance so far has been wider-than-the-screen textareas.

On thing I notice on the screenshots is logout is a bit close to the other navigation, that would be annoying to accidentally click.

Let's get this up on a development site so we can get a little testing and a patch against bluecheese. Details on the setup are at http://drupal.org/node/1018084. Unless there are objections, I'll give frjo access, see if the existing mobile dev site has any changes, and rebuild it, so it is current.

frjo’s picture

Since Android is using Webkit mobile just as the iPhone I assume my suggestion will work as well for Android as for iPhone.

I have implemented this solution on my own blog at xdeb.org so if any Android users would like to try it out and report the result here I would be grateful.

hass’s picture

@frjo: Have you seen that all textareas are not resizable on iphone? I have tried to edit the Google Analytics project homepage and under "Project information" we have this splitted "Description". I was not able to scoll down to the bottom and there is more text as shown :-(

The project home edit page is only one example and it's also broken on this issue comment form textarea. If you need to write very long text you are currently out of luck as the resizable textareas don't show a scrollbar and you cannot move to the bottom and you cannot resize it.

frjo’s picture

@hass,you can actually scroll the textareas on the iPhone. Simply drag with two fingers inside the textarea. Not obvious but works well when you have figured it out.

rcweb31’s picture

are there any mobile friendly interface or theme already for drupal for android or iphone phone that are free?

would love to see drupal site running on these phone systems.

Steven Jones’s picture

@drumm

Mobile is 1.2% of our traffic and probably growing. Certainly worth doing if people have time/motivation to spend doing it, but for now Durpal.org is a primarily-computer site.

What are statistics today?

It would be good to get some movement on this, drupal.org is a poor example of Drupal on mobile devices.

drumm’s picture

1.69% of total visits in the last 30 days as tracked by Google Analytics. Details on operating systems are attached. Roughly, iOS is 2/3 and Android is 1/3.

Steven Jones’s picture

Thanks for the stats.

I think using d.o on an iPad is actually fine at the moment, and we don't need to target it specifically with mobile theming, phone size devices are much more of an issue, d.o borders on unreadable on my iPhone for example, if it was more readable then I'd be much more inclined to browse d.o using it, whereas at the moment I just don't even bother.

Crell’s picture

The most likely think I am to do on a mobile device with d.o is check my issue queues. Those are virtually unreadable right now. I keep trying, and keep failing. :-)

The responsive tables concept that has been bandied about lately may be useful here: http://css-tricks.com/9096-responsive-data-tables/

JohnAlbin’s picture

I have 30 minutes every day to work on issues everyday while traveling on the bus. Currently, I can't use drupal.org because its not mobile-friendly. That's 125 hours a year of my time that the Drupal project could be getting. :-(

Also, the low 1.69% of total visits is artificially low because people know they can't use the issue queue on their phone.

I'm going to try to drum up some interest in at least getting the issue queue responsive. Squeezing the full 960px size into a mobile screen means WAY too much scrolling. The worst part is actually with the comment text box. I've done it a few times; its really painful.

Most likely, to fix the issue, we'll need to tweak bluecheese and Project module. If someone identifies specific Project issues, please cross-post those issue numbers here.

yoroy’s picture

I support the notion of starting with making issue listings and individual issue pages behave mobile friendly. I use the my issues block on the dashboard to get a quick overview of latest changes. The way the data is presented there would work well for me when applied to the specific /project/issues/user/* page with the big table with all my issues.

screenshot of my issues block on dashboard

jensimmons’s picture

Title: Mobile phone support (iPhone / Android) » Support all screen sizes

The problem with using Google analytics numbers to assess the number of mobile phone visitors is that most mobile phones don't run javascript. So they are never, ever counted. ("Most mobile phones" =! Android OS phones or iPhones).

Modern responsive web design techniques will handle all the concerns raised on this thread. Look outside the Drupal community, and you'll find a wealth of knowledge on how to do this.

http://mobilewebbestpractices.com/resources
http://www.abookapart.com/products/mobile-first-responsive-web-design-bu...
http://stuffandnonsense.co.uk/projects/320andup
http://www.cloudfour.com/blog
http://www.netmagazine.com/features/ethan-marcottes-20-favourite-respons...
http://google.com

Applying a fluid, responsive layout to the issue queue lists and issue pages won't just help phones — it will help anyone who wants to keep their browser narrow... say, uh, like a certain Drupal 7 maintainer who loves to make her browser windows 500px-ish wide. Shorter line-lengths of text is more readable in any context.

hass’s picture

Sounds plain wrong. The most mobile clients that are ready for internet have browsers with javascript support. With WAP you cannot browse any website. WAP IS dead and was ever dead from first day. The mobile smartphone hype comes only from real smartphones with full-fledged web browsers. All other mobile phones are not capable to show websites (the ones you refer, too)

Steven Jones’s picture

Okay, so if someone comes to this thread and decides that they'd like to help in getting at least some of d.o into a mobile friendly format what would their next steps be? Would they need a drupal.org approved development environment thingy?

drumm’s picture

cweagans’s picture

I don't think there's anyone here that would particularly care if WAP was officially supported. As hass said, WAP is long dead.

Crell’s picture

WAP isn't the point. "The server cannot reliably know what the viewport size will be, so don't pretend that you can" is the point, and that much is absolutely true. (Remember, viewport. Just because someone has a really big screen doesn't mean they have a really big browser window. I almost never have my browser maximized these days.)

We need to make Bluecheese responsive. That's all there is to it. Especially given that we want to make Drupal the premiere mobile and HTML5 CMS on the market. Our own website should follow those modern approaches, too.

jensimmons’s picture

Hass said
"Sounds plain wrong... All other mobile phones are not capable to show websites. "

Yeah, that's why it's best to not go by what "sounds right", but instead look to industry experts who are tracking statistics. I recommend Pete-Paul Koch, Stephanie Rieger, Bryan Rieger, and Luke W's research to name a few. Search around and you can find presentations by all of them where they debate these issues with statistics and results of extensive testing.
http://www.quirksmode.org/mobile
http://stephanierieger.com
http://bryanrieger.com
http://www.lukew.com/ff

Or skip the fighting, and simply do what Larry said: "We need to make Bluecheese responsive. That's all there is to it."

cweagans’s picture

I agree that we need to make Bluecheese responsive, but I don't think we should care about supporting WAP browsers. We dropped IE6 and IE7 support in core because they were old crufty browsers that we really hated. I think we should do the same with WAP browsers.

jrbeeman’s picture

I think a related consideration, outside of the very important discussion about page appearance, is the potential length of some of the issue pages. For example, #76824: Drupal should not handle 404 for certain files contains over 300 posts. Currently, it appears that issue nodes don't start paging comments until the 301st comment is made. On a mobile device, this could be brutal. I just tried to pull up that issue on my iPhone 4 and there was a significant lag in rendering the page. Once the page rendered, it was quite long (lots of thumb-scrolling), and this is with the text so small it's illegible without zooming in. Once we make the text legible, the page is bound to be longer in so far as the user experiences it.

I'm not sure I have a solution to propose to this issue at the moment, but wanted to get it noted. I feel like anchors / jump points are part of the solution, but not sure how.

Michelle’s picture

Issues page at 301 because "new" links don't work properly with pagers and it's a real PITA to find the first new comment on pages after the first page when there is no jump link and, worse, all the "new" markers are gone if you went to page 1 first (and therefore marked the issue "read").

Michelle

Steven Jones’s picture

Note that we have requested a sandbox for development of this issue here:
#1435260: I want a drupal.org development site for making bluecheese adaptive

Steven Jones’s picture

We now have our sandbox, yey!

LewisNyman’s picture

Plan of action

Ok guys, I've had a bit of a play about in firebug to figure out what our pain points are. Let me know if you disagree with any of this:

  1. Throw some mobile friendly meta tags in there
  2. Convert the grid system to % instead of pixels using the target / context equation. It's important that we leave the main page wrapper fixed at 960px during this period so we can verify the proportions match the pixel based layout.
  3. Remove any crazy set heights.
  4. Take off fixed 960px width off the main page wrapper.
  5. Add single Desktop first media query to switch to a single column layout.
  6. Bug fixing

It's not going to be a perfect, shining example of how to do responsive design but it's a lot better than what we have now. The objective is to get this fix out before the end of this year. Considering how busy everyone is doing mobile stuff for Drupal core I think this will be challenging enough.

Steven Jones’s picture

@lewisnyman that sounds great, thanks for writing that up. I've re-done the issue summary with that information.

rudiedirkx’s picture

Excellent. How do I help?

cweagans’s picture

rudiedirkx, I appreciate your enthusiasm, but I have unpublished your comment. We absolutely do NOT want to encourage users to log into Drupal.org through a proxy. If you feel that this is an extreme measure, you're welcome to open an issue about it in the webmaster queue.

It sounds like this issue is going to gain some attention as part of the Drupal 7 migration later this year.

rudiedirkx’s picture

Not a problem. Not an extreme measure either. But somebody should do something. 40 comments about nothing in 18 months is just bad.

So I'll repeat my original question: How do I help?

drumm’s picture

See the issue summary, there is a plan and a link to a dev site with some work in progress. For information on getting ssh access to help with the dev site, see http://drupal.org/node/1018084.

Steven Jones’s picture

Yeah so we have a dev site where some work has taken place to convert bluecheese to a responsive grid, however the design is actually quite inflexible and certain pages on Drupal.org are kinda designed for being 960px wide, e.g. Most of the places where there are three or four columns of actual content.
I'm wondering if a good way to go would be to target some of the easier pages and make just those responsive/adaptive, and then leave the harder bits for a full on redesign. So far the really 'nice' responsive or adaptive sites I've seen tend to look quite sparse when viewed on a desktop, whereas drupal.org is not sparse at 960px.

There's no need to lump this in with upgrading to D7 unless funding both together makes sense, unless I'm missing something.
Let's be clear: making Drupal.org usefully responsive may be as challenging to do as upgrading to D7 itself.

Steven Jones’s picture

Sorry, my previous post was written on my phone at 10:30PM, so probably didn't make much sense.

Basically, I'm suggesting that we change the short-term plan to make all pages responsive, but artificially fixed to 960px wide, and then only make certain pages adaptive. Yes, this sucks.

When the D7 upgrade comes along, we just change bluecheese to become D7 compatible, and we can continue to make more and more pages adaptive until we're done. This will probably quite jarring for users, as they will keep switching back and forth between the two however.

timodwhit’s picture

+1

timodwhit’s picture

This issue is talking responsive theming as well. #1438716: [Meta] Port bluecheese to Drupal 7

LewisNyman’s picture

I've been working at integrating a fluid '960.gs' grid into the Drupal 7 port to see if it flags up any issues.

One really obvious one is common use of nested grid classes. The home page of drupal.org is a great example of where we have classes inside other classes. When the framework was set in fixed pixels it was fine but now they are set in percentages it completely throws everything off. I'm hoping we can tidy up all these nested classes as part of the port.

LewisNyman’s picture

Issue summary: View changes

Updated issue summary.

hass’s picture

You could use the YAML for Drupal theme and you don't need to waste valuable time. No need to re-invent the wheel again and again. Flexible, Responsive, Accessible, 960gs grid bullsh** and everything else you can think of.

drumm’s picture

Since this is being worked on for D7-only, I'd like to destroy responsive-drupal.redesign.devdrupal.org. Is there anything there that needs to be saved?

LewisNyman’s picture

Can we keep it please?

It's a responsive design prototype. We won't use the code but the design decisions made wil indicate the direction we work in.

rupl’s picture

@drumm I have backed up the relevant pieces of that dev instance and we are good to destroy it.

drumm’s picture

Done. Is this issue now a duplicate of any of the ones open for D7?

drumm’s picture

Issue summary: View changes

Issue update including D7 sprint week progress

mgifford’s picture

What happened to the development sandbox? Seems that is gone. Still seems like there's a good plan of action from @LewisNyman on where to go from here.

I guess now that bluecheese is a release this could be done locally and then submitted back as a diff, right?

mgifford’s picture

Google's Pagespeed Insights gives the Drupal home page a 59/100:
http://developers.google.com/speed/pagespeed/insights/?url=drupal.org&ta...

Funny to see things listed as rendering 3 & 4 pixels tall.

What percentage is Drupal's mobile traffic anyways?

LewisNyman’s picture

The d.o traffic is split:

  • Desktop - 94.58%
  • Mobile - 3.84%
  • Tablet - 1.58%

It's kind of hard to glean anything useful from these stats because using drupal.org on a phone is really hard right now. I avoid it. I read issue queue comments on my phone via email.

We're in a pretty good place now to start working on getting Bluecheese responsive, the entire grid is fluid. We just need to remove that 960px set width container and start looking at what breaks. I'm hoping we'll have opportunity to coordinate at Szeged.

mgifford’s picture

Status: Active » Needs review
FileSize
7.05 KB

I figured I'd start by bringing it over to HTML5 based on Bartik.

This definitely still needs lots of work to get to #37, but I figured I'd start there to get us looking at it.

mgifford’s picture

FileSize
17.66 KB

Now with some CSS & mobile friendly meta tags.

This still definitely needs a lot of care. I'm not a themer.

LewisNyman’s picture

I forgot to mention here that we are working on this at the Drupal Dev Days sprints in a sandbox: https://drupal.org/sandbox/lewisnyman/2224375

You can view a most recent version of the theme here: https://sprint5-drupal.redesign.devdrupal.org

Feel free to get involved on IRC in #drupaldevdays or post issues to the sandbox issue queue.

mgifford’s picture

Excellent, glad this is a focus for one of the sprints!

LewisNyman’s picture

We need to discuss the workflow for getting the responsivesandbox merged into the actual Bluecheese repo. There's no good in it sitting there going stale.

Should I create a new issue where we can discuss gates?

drumm’s picture

Let's stick to this issue. I think the next steps are:

  • Move the Git branch from responsivesandbox to the 7.x-2.x branch of this project. Having the branches in the same place will be more simple Git commands as we diff & merge this toward reality.
  • Update our build script, http://drupalcode.org/project/infrastructure.git/blob/refs/heads/master:..., to work with both branches.
  • Review the diff, keep merging in 7.x-1.x changes, and come up with a test plan.

I want to clear out the 7.x-1.x issues needing review before concentrating on this myself.

LewisNyman’s picture

Hi,

I have to say that it's a real shame this still isn't on a roadmap at all. A weeks worth of hard work from 4/5 people is being left to go stale while bluecheese elements are restyled and pages redesigned with no consideration of mobile, which just piles up the work somewhere else until this gets looked at again.

I understand it might be low down on the list of priorities, but not communicating anything at all is a little disrespectful for the time and effort made here. I hope times have changed and we have many more frontend contributors to drupal.org, because it will be hard for me to look anyone involved in the eye and encourage them to contribute to d.o again when their work is still gathering dust.

drumm’s picture

This is something we (Association staff) do want to tackle this year. Unfortunately, it hasn't risen to be close enough to the top of any list to be well-communicated about. We currently need to concentrate on things like D8 core blockers and D7 upgrade regressions. https://assoc.drupal.org/jobs#op-33503-drupalorg-web-designer will of course make the biggest impact.

I want to clear out the 7.x-1.x issues needing review before concentrating on this myself.

I have been able to get that backlog down by quite a bit. There are a couple color-related issues now, that shouldn't need to be blockers.

Next steps:

  • #2228139: Improve line wrapping in tables should be gotten out of the way.
  • I'd like to see merges from bluecheese upstream in the responsive sandbox. I may take this on myself, if I have access.
  • Updating the build script, as I mentioned in #62.
drumm’s picture

Another big next step - a QA plan. We should write down which browsers we will primarily support vs. make sure things are not broken. Which Drupal.org pages need to look great for this first pass?

webchick’s picture

For now, I'd say focus on the home page (but without messing up e.g. the issue queue) + the latest versions of Android + iOS. We can always add more pages/browsers later.

yoroy’s picture

I'm attaching the top 20 pages for: 1. all visits, 2. mobile traffic (±2.25% of total) and 3. new users (23.67% of total) from the last three months.

I think it'd be good to get

/start
/drupal-8.0
/documentation
/node-258 (understanding drupal)
/about

in good shape as well

LewisNyman’s picture

I'd like to see merges from bluecheese upstream in the responsive sandbox. I may take this on myself, if I have access.
Updating the build script, as I mentioned in #62.

I would be nice if we could get to the point where others in the community can test can give feedback, so we can iterate. I don't think there are any problems on http://responsive-drupal.redesign.devdrupal.org that are so major that they block testing.

LewisNyman’s picture

I've opened an issue so I can help merge the sandbox into a new branch: #2312319: Request for maintainership

For now, I'd say focus on the home page (but without messing up e.g. the issue queue) + the latest versions of Android + iOS. We can always add more pages/browsers later.

I'm attaching the top 20 pages for: 1. all visits, 2. mobile traffic (±2.25% of total) and 3. new users (23.67% of total) from the last three months.

I think it'd be good to get

/start
/drupal-8.0
/documentation
/node-258 (understanding drupal)
/about

in good shape as well

I'm not sure if it is clear that we've already worked on these pages (and more) to a decent state in the sandbox, I've added links in the quotes. I was hoping we'd get some kind of specific feedback on these pages. Was it just not clear that there is anything to test?

yoroy’s picture

That indeed wasn't clear to me, thanks for linking.

drumm’s picture

The responsive sandbox's 7.x-1.x branch is now 7.x-2.x in this project, and Lewis is a maintainer of that branch. #2312319: Request for maintainership

Before we move forward with this, some housekeeping needs to happen:

  1. Merge 7.x-1.x into 7.x-2.x to get upstream changes. There are some merge conflicts, but fewer than I was expecting.
  2. Change anything overriding drupalorg code, such as drupalorg-home.tpl.php and home.js into patches for drupalorg. Site-specific code overriding site-specific code is not maintainable.
  3. Change the template.php additions into patches for drupalorg or drupalorg_crosssite. No new PHP should be added to the theme unless absolutely necessary.
  4. I think #2228139: Improve line wrapping in tables should have a resolution on the 7.x-1.x branch.
  5. Anything else practical to make the diff between 7.x-1.x and 7.x-2.x smaller and more reviewable.
webchick’s picture

Priority: Normal » Major

This feels at least major to me, given that one of the huge features of D8 is better mobile support. Would be pretty embarrassing for the website D8 is distributed on to not work well on a cell phone. :)

rudiedirkx’s picture

It's embarrassing now. This has been an issue for almost 4 years, and there's 0 public progress.

drumm’s picture

Status: Needs review » Needs work

Setting to needs work, since the next steps are listed in #71.

DyanneNova’s picture

Assigned: Unassigned » DyanneNova

I've merged 7.x-1.x into 7.x-2.x. My next plan is to get the drupalorg components split out.

hass’s picture

A week or two ago someone has broken d.o on iphone completely. Can someone rollback this, please?

DyanneNova’s picture

@hass We haven't made any changes to the live theme yet for this issue. Could you file a separate issue with details on what's broken for you?

joshuami’s picture

Issue tags: +d.o responsive
DyanneNova’s picture

We have a testing sprint happening at BADCamp today. You can also look for bugs at home at https://rwd-drupal.redesign.devdrupal.org and post notes in the spreadsheet at https://docs.google.com/spreadsheets/d/1IIUNKqjvmV8FXIVf86y0tMLoqo3fpYC8...

mgifford’s picture

I think the question really should be, is there anything here which makes it worse for desktops? Right now it's unusable for mobile devices. If there's no degradation for desktops, why can't we just implement it?

There are a few improvements that have been noted in the spreadsheet, but as far as I've seen there's nothing making it worse for existing users. And lots making it better for others.

This doesn't have to be perfect to roll out. It just has to be better. I think this is already way better.

  • drumm committed 1f13846 on 7.x-1.x
    Issue #951114: Backport SASSifying front-current/thisweek-activity from...
  • drumm committed 69d8c79 on 7.x-1.x
    Issue #951114: Backport removing the home page map on...

  • drumm committed 1f13846 on 7.x-2.x
    Issue #951114: Backport SASSifying front-current/thisweek-activity from...
  • drumm committed 69d8c79 on 7.x-2.x
    Issue #951114: Backport removing the home page map on...
  • drumm committed 81dd247 on 7.x-2.x
    Issue #951114: Merge branch '7.x-1.x' into 7.x-2.x
    
    Conflicts:
    sass/...
drumm’s picture

Issue summary: View changes

Change anything overriding drupalorg code, such as drupalorg-home.tpl.php and home.js into patches for drupalorg. Site-specific code overriding site-specific code is not maintainable.

Good progress is being made here. My commits are keeping 7.x-1.x in line with changes we can deploy for drupalorg.

I've updated the Remaining tasks in the issue summary with comment #71.

drumm’s picture

Issue summary: View changes
Issue tags: +Needs issue summary update

Crossing off 2 & 3 in the remaining tasks.

The rest of the issue summary, especially the Proposed resolution and Update, looks like it could be spruced up, and I'm not qualified to do that.

  • drumm committed b3f96fb on 7.x-2.x
    Issue #951114: Merge cleanup.
    

  • drumm committed f560c91 on 7.x-2.x
    Issue #951114: Remove @imports replaced by globbing in sass/styles.scss
    
mgifford’s picture

This hasn't been deployed yet, right? Doesn't seem to have been.

Last two points from the summary seem to be:
- Does deployment depend on #2228139: Improve line wrapping in tables ?
- Any changes to keep 7.x-1.x inline with 7.x-2.x to make it easier to maintain

There's nothing here to indicate that the code we have now isn't substantially better for everyone as it stands right now.

YesCT’s picture

Looks like it is planned Dec 22-28 2014 Drupal.org changes: https://www.drupal.org/node/2395913

drumm’s picture

Indeed, we're hoping to deploy this ~1.5 hours from now. It is currently deployed on https://staging.devdrupal.org

drumm’s picture

Status: Needs work » Needs review
Issue tags: +needs drupal.org deployment
drumm’s picture

Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Needs review » Fixed
Issue tags: -needs drupal.org deployment

The initial deployment is done. More page-by-page work will certainly be needed, and should be handled in separate issues on the 7.x-2.x version, such as #2228139: Improve line wrapping in tables.

Subsites running on D7 will be updated as we are able to test them.

Wim Leers’s picture

Do we report bugs here or elsewhere? Just load this very page on an iPhone, and you'll find many bug problems (significant whitespace gutter on the right hand side, "most recent comment" jump link… below all comments, hence being useless, and so on).

But don't get me wrong: I'm very happy and grateful this is happening! :)

attiks’s picture

#92 probable cause a file attachment table, see screenshot

attiks’s picture

Status: Fixed » Active

Is it possible to move the "jump to" links to the top?

PS reopening for now until we now how to report problems

drumm’s picture

Status: Active » Fixed

I included how to report problems in #91:

More page-by-page work will certainly be needed, and should be handled in separate issues on the 7.x-2.x version

drumm’s picture

#2228139: Improve line wrapping in tables deals with tables forcing widths, so #92-93 can be handled there.

LewisNyman’s picture

"most recent comment" jump link… below all comments, hence being useless, and so on).

@drumm Which project should this issue be raised against? We just need to move a block to the other region right?

drumm’s picture

YesCT’s picture

YesCT’s picture

noticed some new issues related to this.

do we want to tag all issues related as mobile? or d.o responsive? I checked and this is the only issue in this queue using those tags

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

YesCT’s picture