It might clean up the interface if each group was given it's own callback.

Patch coming so we can test this.

CommentFileSizeAuthor
#8 styleguide-subtasks-950884-8.patch3.81 KBmrfelton
#5 styleguide-subtasks-950884-2.patch3.83 KBjgj
#4 950884-styleguide-subtasks-2.patch3.81 KBsquiggy
#1 Picture 3.png30.03 KBagentrickard
#1 950884-styleguide-subtasks.patch4.4 KBagentrickard
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard commented
Status: Active » Needs review
FileSize
950884-styleguide-subtasks.patch4.4 KB
Picture 3.png30.03 KB

Might make things easier, but I would want to be able to jump from 'Bartik' forms to 'Seven' forms, and I don't think the menu supports that.

squiggy’s picture

squiggy CreditAttribution: squiggy commented

I agree, this would be a useful change to the UI.

In fact, I started a similar module, which renders different types of output under separate subtabs like this.

(Fyi, here's an issue filed about overlap between Style guide and the module I started: http://drupal.org/node/1088416)

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard commented

Yeah, we need to merge all of these efforts. We have a discussion over in Design, too.

I like the subtabs, but haven't given it much thought recently.

squiggy’s picture

squiggy CreditAttribution: squiggy commented
FileSize
950884-styleguide-subtasks-2.patch3.81 KB

Updated patch for current dev branch.

jgj’s picture

jgj CreditAttribution: jgj commented
FileSize
styleguide-subtasks-950884-2.patch3.83 KB

This was the first thing I thought of when I tried this module out. Tried the patch in #4 against 7.x-1.x branch from git and it didn't apply. Manual copying didn't work quite as expected. Moved the loop that sets up the secondary tabs into the loop that sets up the primary tabs and it's working for me. Patch provided :)

jgj’s picture

jgj CreditAttribution: jgj commented

scratch the 2nd to last sentence in my previous post. I just copied wrong from the patch in #4 :)

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard commented
Status: Needs review » Needs work

I would, I think, much prefer doing this with AJAX -- faster and cooler. The only concern I have with using AJAX is that it might distort the presentation of elements, but I don't think that's very likely.

There is also a stray dpm() in the patch.

I also get this message when clearing cache, but only with the patch applied:

Cannot modify header information - headers already sent by (output started at                                [warning]
/Applications/MAMP/drush/commands/core/clear.cache.inc:2) bootstrap.inc:1243
mrfelton’s picture

mrfelton CreditAttribution: mrfelton commented
Status: Needs work » Needs review
FileSize
styleguide-subtasks-950884-8.patch3.81 KB

Attached patch removed rogue dpm call and fixes trailing whitespace issues in previous patch.

Status: Needs review » Needs work

The last submitted patch, styleguide-subtasks-950884-8.patch, failed testing.

webcultist’s picture

webcultist CreditAttribution: webcultist commented
Issue summary: View changes

Just tried this patch. Works great :)
Should be updated for the latest dev and tested by more people, but it's a very nice improvement - THANKS 4 this!