There are just too many issues with image_fupload, and swfupload doesn't natively support the one-image-per-node paradigm. plupload is small, simple, more supported in browsers, and easy to integrate with.

I already have a POC working locally, and it's just much smoother than image_fupload. Stay tuned for a patch.

CommentFileSizeAuthor
plupload.png71.95 KBjustintime
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

igorik’s picture

igorik CreditAttribution: igorik commented

nice to hear this!

thanks for your effort.

justintime’s picture

justintime CreditAttribution: justintime commented
Status: Active » Needs review

Just committed in initial code for integration into 3.x. If you'd like to try it out:

  1. Install the latest 3.x dev build.
  2. Download and install plupload. Note that you need to download a separate zip that includes the plupload libraries. Follow the README.txt included in the module.
  3. Patch plupload with this patch. It's required. I see know reason why greggles wouldn't commit it, it's a bug fix. Until he does, you have to apply the patch.
  4. Visit admin/settings/plupload-bulk, and set the target field to be Gallery Image: Gallery Image.
  5. Ensure plupload integration is enabled at admin/settings/node_gallery/settings - it should be by default, let me know if not.
  6. Clear all caches.
  7. Visit a Gallery page, click on the "upload new image" tab.
  8. Emit many "ooohhh"'s and "aaahhh"'s.
  9. After uploading the files, note the help text above the plupload widget that says to visit Manage Images. Do that.
  10. Note that the Manage Images tab is only showing you the newly uploaded images.

Plupload's beauty is in it's simplicity. It's an uploader that creates nodes, and that's it. A lot of the flakyness in image_fupload is around it trying to be a jack of all trades.

Since we already have a Manage Images form, I just adapted it a bit to make the workflow a bit more intuitive. After you upload your images via plupload, you'll be at the same page you were before. The nodes have been added, and associated with the gallery, but nothing else has been done to them. Your next visit to the Manage Images tab after uploading new images will only show you the newly uploaded images with paging disabled. When you come back (or simply click the Manage Images tab again), you'll be presented with all the images in the gallery, in a paged format.

Personally, I love this approach. image_fupload was duplicating a lot of the Manage Images tab in a different way. This new way is much more seamless.

Thoughts?

Delty’s picture

Delty CreditAttribution: Delty commented

I wanted to try it out, but the latest dev build is from yesterday and definitely doesn't have the option to use plupload. I'm being forced to withold my "ooohhh"'s and "aaahhh"'s against my will!

-=Delty

Delty’s picture

Delty CreditAttribution: Delty commented

From my experimentation last night, this is a much much better solution than FUpload. It's much more intuitive and the flow is far more logical. Many of my contributors don't want to add titles, captions, or descriptions, so being able to upload a bunch of images and skip a visit to the Manage Images tab will be a real godsend to my constituents.

The only caveat that I can see so far is its incompatibility with IE8 in the current iteration. As much as we-in-the-know dislike it, the majority of users sill rely on it, at least on my sites. I'm sure, though, that greggles will add Flash and Silverlight support to his module at some point in the near future.

This is definitely a change for the better.

Thanks!

-=Delty

justintime’s picture

justintime CreditAttribution: justintime commented

Ugh. Flipping IE. I should have thought to test that.

Yeah, that's definitely a blocker. I'll file an issue for it over in the plupload queue and see where it's at on the priority list.

justintime’s picture

justintime CreditAttribution: justintime commented

Patch for IE support (via flash) posted over in the plupload issue queue. I'd love it if people could test and verify success over in that issue so that greggles doesn't have to do much work.

justintime’s picture

justintime CreditAttribution: justintime commented
Status: Needs review » Needs work

Just a note that after applying the patch referenced in #6, plupload with IE+flash works, but the association between the newly created image node isn't associated properly with it's gallery. This is a bug in the NG3 integration code and not in plupload.

justintime’s picture

justintime CreditAttribution: justintime commented
Status: Needs work » Needs review

Well, just dove in head first. Meet the newest co-maintainer of plupload :). I found a few bugs that have been in plupload since it's inception, but aren't exposed until you use a non-HTML5 uploader (like flash+IE). I'll be making some commits later today to that project that should get things in order.

Delty’s picture

Delty CreditAttribution: Delty commented

The flash version works well, and it seems, based on a look at the code, that it would be easy to implement the other upload types (Silverlight, Gears, Browserplus) and add admin control over which ones to use and in which order.

Also, there is a typo in the browser support error message. "You browser..." should be "Your browser..."

Now all we need is a patch to NG that takes care of the node association issue with the parent gallery.

Thanks!

-=Delty

justintime’s picture

justintime CreditAttribution: justintime commented

Given that with image_fupload we were okay with forcing Flash to do bulk uploads, I'd rather keep plupload as simple as possible. Not to mention that the more runtimes we support, the more bugs in the core plupload library we'll encounter.

I think the integration work is pretty much done. I've made a couple commits to plupload head, grab the latest dev from there, and then apply the patch from here. Finally install the latest 3.x dev, and you should have a fully working plupload+node_gallery integration going, no matter the browser.

I also fixed that typo - thanks.

Delty’s picture

Delty CreditAttribution: Delty commented

So far so good - I uploaded 80 pics to various test galleries and noticed no issues, even with FielField Paths enabled. Everything went to the correct location and was added to each gallery successfully. This is so much better - thank you for taking the time to implement this!

-=Delty

scroogie’s picture

scroogie CreditAttribution: scroogie commented

I need to go to plupload settings once and save there. Don't know why. Great work justin, by the way!

justintime’s picture

justintime CreditAttribution: justintime commented
Status: Needs review » Fixed

Well, I think the plupload integration is already less-buggy than the image_fupload one. I'm tempted to rip out the fupload integration code, but I'll hold off until we start getting bug reports in our issue queue about it.

I made one last commit to fix a bug reported in #12 about an unconfigured plupload not working right. I want to stop short of configuring it for them, and instead display a message with a link to the proper page telling the admin what they need to do.

Marking this issue as fixed.

njathan’s picture

njathan CreditAttribution: njathan commented

This is wonderful! Thanks Justin :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

brayo4’s picture

brayo4 CreditAttribution: brayo4 commented

Doed NG3 require any other modules to work with plupload. I keep getting Your browser does not support HTML5 native or flash upload. Try Firefox 3, Safari 4, or Chrome; or install Flash. I have installed and reinstalled all modules as above, including the plupload libraries. Is there a specific jquery version to use, is this even a consideration? Ca s'one please post all modules/sw required to work with chrome/forefox browser??? thanks, been working on this for a week and dont seem to be getting any headway........

scroogie’s picture

scroogie CreditAttribution: scroogie commented

Are you sure that the path to the plupload libraries is correct? Or do you get any error in your javascript console on firefox?

brayo4’s picture

brayo4 CreditAttribution: brayo4 commented

the path is correct and i've installed/reinstalled over 20 times. Is there anyone who has successfully loaded without applying the patch??? maybe i can learn something from them. i tried to patch it but was unable to......

scroogie’s picture

scroogie CreditAttribution: scroogie commented

You don't need the patch anymore. You just install version 6.x-1.x-dev of plupload, download the library from plupload.com and put it in the same folder. It should work then. Please have a look at the javascript error console if there are any proper error messages.

brayo4’s picture

brayo4 CreditAttribution: brayo4 commented

Thank you much for hanging in there with me. What fixed it was rolling back to jquery 1.6 . Works like a charm....back to plan A.....

kouri’s picture

kouri CreditAttribution: kouri commented

@ scroogie #19

Can you confirm that the content of both /plupload dirs (the one from plupload integration module page and the one from plupload.com site) must be mixed into drupal/modules/plupload/ directory ?

scroogie’s picture

scroogie CreditAttribution: scroogie commented

You extract the plupload archive from plupload.com into the plupload subfolder in the module folder, yes. So in the end you have

/sites/all/modules/plupload/

with the modules files in and

/sites/all/modules/plupload/plupload/

with the plupload files (js/ src/ etc.) in.

kouri’s picture

kouri CreditAttribution: kouri commented

Thank's for preciseness.
;)

I reinstalled the plupload integration module but it is now unactivable (uncheckable) in module list

:(

baskin’s picture

baskin CreditAttribution: baskin commented
Version: 6.x-3.x-dev » 6.x-3.0-beta2
Status: Closed (fixed) » Active

I have the error described below. I can see that this fellow is using drupal as well. My installation is fresh (6.22) and i'm using Node Gallery 6.x-3.0-beta2 and latest plupload.

https://github.com/moxiecode/plupload/issues/173

dddave’s picture

dddave CreditAttribution: dddave commented
Status: Active » Closed (fixed)

Please don't arbitrarily open old issues. If you want to report this issue please do so in the plupload module issue queue but check first if there is already an issue about this problem.

artiprasad’s picture

artiprasad CreditAttribution: artiprasad commented
Version: 6.x-3.0-beta2 » 7.x-1.x-dev
Issue summary: View changes

I am getting the same error but till not finding solution "Your browser does not support HTML5 native or flash upload. Try Firefox 3, Safari 4, or Chrome; or install Flash.". I already updated plupload jQuery but then also this error is appear done various settings but not get solution.