Improvements to cod_sponsors [#941948]

Includes more fields, permissions, better labeling, ordering etc. developed with ezra-g

Comment	File	Size	Author
#2	sponsors.diff	32.39 KB	ezra-g
#2
	cod_sponsors_oct10.zip	72.35 KB	lisarex

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

ezra-g CreditAttribution: ezra-g commented 16 October 2010 at 18:11

Status:

Active

» Needs review

Comment #2

ezra-g CreditAttribution: ezra-g commented 1 January 2011 at 00:03

File	Size
sponsors.diff	32.39 KB

Here this is as a patch for easier review.

Comment #3

coltrane

he/him

CreditAttribution: coltrane commented 6 January 2011 at 21:56

+++ cod_sponsors/cod_sponsors.features.fieldgroup.inc	1 Jan 2011 00:03:02 -0000
@@ -0,0 +1,63 @@
+        'description' => '',

How about a help description when creating a sponsor? How about "Provide the primary sponsorship contact for use by visitors" ?

+++ cod_sponsors/cod_sponsors.info	1 Jan 2011 00:03:03 -0000
@@ -46,11 +60,11 @@ features[variable][] = "comment_form_loc
-features[views][] = "sponsors_admin"

and,

+++ cod_sponsors/cod_sponsors.views_default.inc	1 Jan 2011 00:03:03 -0000
+++ cod_sponsors/cod_sponsors.views_default.inc	1 Jan 2011 00:03:03 -0000
@@ -239,23 +239,6 @@ function cod_sponsors_views_default_view

Should this view be getting removed?

Powered by Dreditor.

Comment #4

ezra-g CreditAttribution: ezra-g commented 8 January 2011 at 22:54

Status:

Needs review

» Needs work

Adding a description seems good.

Removing the sponsors admin view does seem like a mistake since we only have one of those.

Other things I see reviewing this patch:

Things I like:

- changes title => company
- body => company description
- permissions for editing fields.
- View tweaks
- Adds sponsor phone

Things I'm not sure about:
- Adds sponsor email field
- adds sponsor first
- adds sponsor last
- adds contact info field group

Do we want to replace the first/last and email with a user reference to "official sponsor contact person" instead? Having a first and last name on an organization profile seems weird.

Also, I think we should probably commit the improvements from this patch with 'sponsor' replaced with 'organization', so we don't create much extra work for #1010020: Replace "sponsor" references with "organization".

Comment #5

lisarex CreditAttribution: lisarex commented 9 January 2011 at 19:34

Yes, a user reference makes sense. Maybe even two? Often there's a CEO-type who is the person who signs the sponsorship agreement but there's someone else who is handling everything else including providing the logos and is interested in where their sponsor table is in the venue.

Let's do another patch