Includes more fields, permissions, better labeling, ordering etc. developed with ezra-g

CommentFileSizeAuthor
#2 sponsors.diff32.39 KBezra-g
cod_sponsors_oct10.zip72.35 KBlisarex
Members fund testing for the Drupal project. Drupal Association Learn more

Comments

ezra-g’s picture

Status: Active » Needs review
ezra-g’s picture

FileSize
32.39 KB

Here this is as a patch for easier review.

coltrane’s picture

+++ cod_sponsors/cod_sponsors.features.fieldgroup.inc	1 Jan 2011 00:03:02 -0000
@@ -0,0 +1,63 @@
+        'description' => '',

How about a help description when creating a sponsor? How about "Provide the primary sponsorship contact for use by visitors" ?

+++ cod_sponsors/cod_sponsors.info	1 Jan 2011 00:03:03 -0000
@@ -46,11 +60,11 @@ features[variable][] = "comment_form_loc
-features[views][] = "sponsors_admin"

and,

+++ cod_sponsors/cod_sponsors.views_default.inc	1 Jan 2011 00:03:03 -0000
+++ cod_sponsors/cod_sponsors.views_default.inc	1 Jan 2011 00:03:03 -0000
@@ -239,23 +239,6 @@ function cod_sponsors_views_default_view

Should this view be getting removed?

Powered by Dreditor.

ezra-g’s picture

Status: Needs review » Needs work

Adding a description seems good.

Removing the sponsors admin view does seem like a mistake since we only have one of those.

Other things I see reviewing this patch:

Things I like:

- changes title => company
- body => company description
- permissions for editing fields.
- View tweaks
- Adds sponsor phone

Things I'm not sure about:
- Adds sponsor email field
- adds sponsor first
- adds sponsor last
- adds contact info field group

Do we want to replace the first/last and email with a user reference to "official sponsor contact person" instead? Having a first and last name on an organization profile seems weird.

Also, I think we should probably commit the improvements from this patch with 'sponsor' replaced with 'organization', so we don't create much extra work for #1010020: Replace "sponsor" references with "organization".

lisarex’s picture

Yes, a user reference makes sense. Maybe even two? Often there's a CEO-type who is the person who signs the sponsorship agreement but there's someone else who is handling everything else including providing the logos and is interested in where their sponsor table is in the venue.

Let's do another patch

mrconnerton’s picture

Version: 6.x-1.x-dev » 7.x-2.x-dev
Issue summary: View changes

We are no longer supporting Drupal 6 cod. We need to compare the latest patch to see what is and is not already completed in D7 version.