All of the name/title gadgets need to use D7's new method for doing that. [#941800]

Comment	File	Size	Author
#10	941800-machine-names.patch	7.89 KB	merlinofchaos
#9	941800_admin_nameV2.patch	1.73 KB	aspilicious
#3	941800_admin_name.patch	3.36 KB	aspilicious

Comment #1

merlinofchaos CreditAttribution: merlinofchaos commented 1 January 2011 at 22:29

Here's a patch for Views that shows us how: http://drupal.org/node/1011220#comment-3888838

Log in or register to post comments

Comment #2

aspilicious CreditAttribution: aspilicious commented 2 January 2011 at 13:42

I'm on it

Log in or register to post comments

Comment #3

aspilicious CreditAttribution: aspilicious commented 2 January 2011 at 14:11

File	Size
941800_admin_name.patch	3.36 KB

Sadly this wasn't as trivial as the views patch.
I don't know what the exist functions are for these functions.
Couple of todo's

BTW:
Why don't you use #required = true in your forms?

?

Log in or register to post comments

Comment #4

aspilicious CreditAttribution: aspilicious commented 2 January 2011 at 14:12

Status:

Active

» Needs review

Log in or register to post comments

Comment #5

merlinofchaos CreditAttribution: merlinofchaos commented 2 January 2011 at 16:45

Because I use a lot of 'cancel' and 'back' buttons and until very very late in the CTools form code, you could not skip the #required validation. It is bad UX to require someone to fill in a form field in order to cancel it, so for the most part, I dropped #required from my memory as something that is unusable.

Log in or register to post comments

Comment #6

merlinofchaos CreditAttribution: merlinofchaos commented 2 January 2011 at 16:48

The 'exist' function for a page manager page is probably page_manager_page_load()

For the other ones, that might be a little tougher. I don't suppose can can provide arguments to the exists function?

Log in or register to post comments

Comment #7

aspilicious CreditAttribution: aspilicious commented 2 January 2011 at 16:57

exists: A function name to invoke for checking whether a submitted machine name value already exists. The submitted value is passed as argument. In most cases, an existing API or menu argument loader function can be re-used. The callback is only invoked, if the submitted value differs from the element's #default_value.

Log in or register to post comments

Comment #8

merlinofchaos CreditAttribution: merlinofchaos commented 2 January 2011 at 17:06

Sigh. Of course not. You'd think that with the rise of entity API someone would've thought about that, so that you could more easily use generic loaders. That means that we're going to have to make export-ui implementions have a specific loader function so they can use this functionality, *or* we're going to have to make our own version of this that can use a more generic loader (like ctools_export_crud_load)

Unless you're really interested in the nuts and bolts of export-ui and export.inc that might be beyond what you want to work on. If that's the case, we can remove the bit for the custom content and I'll make a note to work on that.

Log in or register to post comments

Comment #9

aspilicious CreditAttribution: aspilicious commented 2 January 2011 at 17:32

File	Size
941800_admin_nameV2.patch	1.73 KB

I only go for novice stuff, never saw ctools code before :).
So that second part is FAR beyond my scope/

I *think* I fixed the page manager...

Log in or register to post comments

Comment #10

merlinofchaos CreditAttribution: merlinofchaos commented 5 January 2011 at 22:37

Status:

Needs review

» Fixed

File	Size
941800-machine-names.patch	7.89 KB

Thanks for the push, aspilicious!

I got this working generically in export_ui thanks to a last minute patch by sun and eaton that made it possible to use a generic 'exists' function on #machine_name -- looks like this is working just fine on all exportables implemented by CTools and Panels. Yay!

This also revealed a bug in stylizer having to do with $form_state['plugin'] being used for two different purposes.

Actual patch committed attached.