Remove 'length' parameter for fields with 'int' type [#938436]

Comment	File	Size	Author
#6	simplenews_scheduler.938436_01.patch	1.86 KB	sgabe

#4	schema_compare_report.png	24.64 KB	pheudo

Comment #1

sgabe CreditAttribution: sgabe commented 11 October 2010 at 17:19

I am sorry but I don't understand what you mean... Could you spell out the problem?

Log in or register to post comments

Comment #2

pheudo CreditAttribution: pheudo commented 11 October 2010 at 17:31

Into the implementation of the hook schema into the simplenews_scheduler.install you used numeric value into the size of integer fields.
Drupal support only "normal, tiny, small, medium, big" attributes. Not the number of byte like 11 or 10.

Than schema module reports simplenews_scheduler tables like not congruent with schema.

Sorry about my lame english. =|

Log in or register to post comments

Comment #3

sgabe CreditAttribution: sgabe commented 11 October 2010 at 17:40

I don't see that problem anywhere, only the activated column has a size field which is set to tiny. Don't you confuse the length with size? They are not the same.

Log in or register to post comments

Comment #4

pheudo CreditAttribution: pheudo commented 11 October 2010 at 17:51

File	Size
schema_compare_report.png	24.64 KB

Maybe schema report can help me...

Log in or register to post comments

Comment #5

pheudo CreditAttribution: pheudo commented 11 October 2010 at 18:01

'lenght' indicate the maximal length of a type 'char', 'varchar' or 'text' field. Ignored for other field types.
For the integers u need to use only the size.

Log in or register to post comments

Comment #6

sgabe CreditAttribution: sgabe commented 11 October 2010 at 18:08

Title:	Data types in table schema don't support byte numbers in field size.	» Remove 'lenght' parameter for fields with 'int' type
Status:	Active	» Needs review

File	Size
simplenews_scheduler.938436_01.patch	1.86 KB

Okay, I see the problem which is that the 'length' is only used for 'char', 'varchar' or 'text' and ignored for other field types, so it can be removed from fields with 'int' type. See the attached patch.