rotating_banner_add_form() error when creating new rotating banner

I get the same issue.

The root of this was that rotating_banner_add_form() was using a reference to $form instead of the $form. That is to say, the first argument was &$form instead of $form.

I committed the fix

Doesn't been fixed; I still have the same issue.

on line 251 of sites/all/modules/rotating_banner/rotating_banner.admin.inc, change

function rotating_banner_add_form(&$form, &$form_state) {

to

function rotating_banner_add_form($form, &$form_state) {

so you are changing &$form to $form as noted in comment 2.

Try checking out HEAD

Worked for me

It didn't work for me:
Warning: Parameter 1 to rotating_banner_add_form() expected to be a reference, value given in drupal_retrieve_form() (line 771 of C:\xampp\htdocs\mymusiced\includes\form.inc).

I tried to change the as you suggest James Im still having the problem after trying to save a slide.

Fatal error: Call to undefined function media_load() in /home/u125asa/www/sites/all/modules/rotating_banner/rotating_banner.module on line 241

Only a temp solution:
aaron from http://drupal.org/node/1216052:
The media_load function no longer exists in the Media module. The MediaFront module needs to be updated to work with major API changes to Media for the 7.x-1.0-beta5 release. Try replacing media_load with file_load and see if that solves that particular issue.

I tried it and it works temporary developers should probably replace it with the proper function.

--
_{Latest drupal 7 sites:
Libri Stranieri and Strane Knjige}

where is the download file??????????????????????????