Backport D7 user cancel API to Drupal 6 [#935120]

I've completed the backport of this API. To work on this I've created a new cvs branch DRUPAL-6--2 and committed. I don't to make a new release of this yet because people could get confused trying to upgrade form 6.x-1.x to 6.x-2.x, and they are two
very different approaches.

DRUPAL-6--2 mimics exactly the way Drupal7 handle user cancellation (including user -> edit -> delete, and admin/user/user bulk operations). The only difference is that node, content, and other modules react to hook_user_cancel and hook_user_delete in D7, and in D6 these two hooks are implemented in user_delete.

There is a lot of code and things must be splitted, but it is working in both ways : foreach() loop when there are no more than 10 items to delete/update (nodes or comments) and in batch process when there are more than 10.

I did manual testing and extensive testing with devel-generate for using the batch api. Anyway, the module still needs testing when interacting with other modules (a required test is using another module that uses comment's module hooks).

There are a few @todos and @tasks in the .module file but could be solved easily. I'm putting the module in a live site for real test and will try to comment any issue I find.

Comment	File	Size	Author
#21	user_delete-n935120-21.patch	37.52 KB	DamienMcKenna
#17	user_delete-n935120-17.patch	39.86 KB	DamienMcKenna
#16	user_delete-n935120-16.patch	1.76 KB	DamienMcKenna
#12	user_delete-n935120-12.patch	39.32 KB	DamienMcKenna
#10	user_delete-n935120-10.patch	31.27 KB	DamienMcKenna
#8	user_delete-n935120-8.patch	0 bytes	DamienMcKenna
#5	user_delete-n935120-4.patch	30.74 KB	DamienMcKenna

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

ilo CreditAttribution: ilo commented 7 October 2010 at 20:54

Version:

6.x-1.x-dev

» 6.x-2.x-dev

put this in the right place.

Comment #2

ilo CreditAttribution: ilo commented 15 November 2010 at 09:32

Sandbox is no longer active.

Comment #3

chuckbar77 CreditAttribution: chuckbar77 commented 26 January 2011 at 07:30

subscribing

Comment #4

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 22 November 2013 at 16:54

Title:	backport D7 user cancel API to Drupal 6	» Backport D7 user cancel API to Drupal 6
Issue summary:	View changes
Status:	Active	» Needs review

This has a number of improvements:

Coding standards improvements, especially comment formatting and removal of erroneous linebreaks between functions.
Added a README.txt file.
Added variable_del() calls to hook_uninstall().
Moved user_delete_cancel_confirm() to user_delete.pages.inc.

I've not tested this yet, but I did at lest run it through a lint test =)

Comment #5

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 22 November 2013 at 17:01

File	Size
user_delete-n935120-4.patch	30.74 KB

oh yeah, the patch.

Comment #6

22 November 2013 at 17:07

Status:

Needs review

» Needs work

The last submitted patch, 5: user_delete-n935120-4.patch, failed testing.

Comment #7

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 22 November 2013 at 17:48

Status:

Needs work

» Needs review

The patch seemed to fail because the D6 Simpletest patch couldn't be applied?

Comment #8

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 26 November 2013 at 19:12

File	Size
user_delete-n935120-8.patch	0 bytes

Ah, user_delete_access() was a duplicate function, so I renamed it to user_delete_delete_access().

Comment #9

26 November 2013 at 19:19

Status:

Needs review

» Needs work

The last submitted patch, 8: user_delete-n935120-8.patch, failed testing.

Comment #10

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 26 November 2013 at 20:50

Status:

Needs work

» Needs review

File	Size
user_delete-n935120-10.patch	31.27 KB

2 files were hidden/shown/deleted

File	Size
user_delete-n935120-4.patch	30.74 KB
user_delete-n935120-8.patch	0 bytes

It'd help if I'd remember to create the patch correctly.

Comment #11

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 26 November 2013 at 20:57

Honestly I think it'd be better to add these options to the existing user settings page (admin/user/settings).

Comment #12

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 26 November 2013 at 21:14

File	Size
user_delete-n935120-12.patch	39.32 KB

This patch moves the new settings into the main user settings form.

Comment #13

26 November 2013 at 21:34

The last submitted patch, 10: user_delete-n935120-10.patch, failed testing.

Comment #14

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 26 November 2013 at 21:53

Status:

Needs review

» Needs work

This needs a little further work, after the user goes through and confirms the account to be deleted, at the end of the batch process the user is dumped at the batch?id=[id]&op=finished page with an "Access denied" message.

Comment #15

26 November 2013 at 22:09

The last submitted patch, 12: user_delete-n935120-12.patch, failed testing.

Comment #16

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 21 December 2013 at 04:44

Status:

Needs work

» Needs review

File	Size
user_delete-n935120-16.patch	1.76 KB

2 files were hidden/shown/deleted

File	Size
user_delete-n935120-10.patch	31.27 KB
user_delete-n935120-12.patch	39.32 KB

I appear to have resolved the problem of the unwanted error showing by adding a drupal_goto() to _user_delete_cancel().

Comment #17

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 21 December 2013 at 04:45

File	Size
user_delete-n935120-17.patch	39.86 KB

1 file was hidden/shown/deleted

File	Size
user_delete-n935120-16.patch	1.76 KB

This is the correct patch.

Comment #18

21 December 2013 at 04:46

The last submitted patch, 16: user_delete-n935120-16.patch, failed testing.

Comment #19

21 December 2013 at 04:47

Status:

Needs review

» Needs work

The last submitted patch, 17: user_delete-n935120-17.patch, failed testing.

Comment #20

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 22 December 2013 at 05:06

FYI right now the messages are not displayed to the end user, so they get bounced back to the front page with no confirmation their account is gone. This is obviously not ideal.

Comment #21

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 2 January 2014 at 18:39

Status:

Needs work

» Needs review

File	Size
user_delete-n935120-21.patch	37.52 KB

1 file was hidden/shown/deleted

File	Size
user_delete-n935120-17.patch	39.86 KB

This fixes the calling of hook_comment in _user_delete_comment_save().

Comment #22

2 January 2014 at 18:41

Status:

Needs review

» Needs work

The last submitted patch, 21: user_delete-n935120-21.patch, failed testing.

Comment #23

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 2 January 2014 at 21:50

FYI I'm personally giving up trying to get v2 to work correctly, every time I run it the user is redirected to the 'finished' batch page and presented with a 403 error. v1 works well enough, just needs a static "your account has been deleted' page added.