Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bjalford’s picture

subscribing

Old Man’s picture

Subscribing

nightowl77’s picture

Ditto

tim.plunkett’s picture

Version: 6.x-1.2-beta2 » 6.x-1.x-dev
Assigned: Unassigned » tim.plunkett
Status: Active » Postponed

I'm looking forward to working on this once Views hits beta. Hopefully we'll have a stable D6 version out for this by then.

rorymadden’s picture

Title: Port to Drupal 7 » Port to Drupal 7 (Full Calendar)

Subscribing.

And changing the name for more clarity in the Dashboard.

tim.plunkett’s picture

I have a working patch for this, but it depends on #992812: Date field discovery code fails on edge cases and #917988: Views options additions and clean-up. Incentive to review those!

geerlingguy’s picture

Just about to get a small site set up in D7, and I'd really like to use FullCalendar if at all possible. I will probably pop in and try to review those other patches asap.

geerlingguy’s picture

Status: Postponed » Active

Looks like the other two commits were made - might you be willing to post up the D7 patch and commit a beta?

tim.plunkett’s picture

Status: Active » Needs review
FileSize
11.9 KB

There are three different types of changes made in this patch:

  • Core changes, like hook_perm() to hook_permission or the inclusion of jQuery UI in core
  • Date API changes, like date_format($date1, DATE_FORMAT_DATETIME) to $date1->format(DATE_FORMAT_DATETIME)
  • CCK -> Field API changes, like not being able to get field values like $node->{$field}[$index]['value']; and using field_get_items() instead

The drag-and-drop code is broken because I didn't port it to use Field API, but that can come in a follow-up. I'd rather get a 7.x-1.x-dev going first.

geerlingguy’s picture

I'll try testing this later today. Getting a -dev release (even if it's quite rough around the edges) out the door should be a top priority. I really think we can get 7.x-1.0 pushed out before the D7 release, which would be awesome.

aspilicious’s picture

FileSize
40.74 KB

Tested it.

I used the standard seven jquery UI theme with some minimal tweaking to get the followng result.
I'm very pleased with it :)

Experience:
- changing from jquery theme to normal displayed a white pages with lots of text :)
==> nothing broken, just had to repeat same steps ==> anoying
- there is always an extra header space before "month" even if you switch the order
- also tested regular html theme, also worked but I preper the jquery UI

==> Is rdy for alpha release

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

Can be set to needs work for the drag and drop stuff

geerlingguy’s picture

I can confirm that it at least works... a D7 alpha would be greatly appreciated :)

[Playing around with it more, it looks like (as stated above) that drag and drop is not working. But that's a minor annoyance, and something tim can contend with in the Entities/Fields API.

But the display works great. For anyone who is trying to sort the view using a field, or doing something else with fields in your view, and getting errors, please see #998666: Adding FieldAPI fields causes "Column not found" errors, expecting an "entity type" field (basically, you need to upgrade to Drupal 7.x dev for now).]

bjalford’s picture

can also confirm that it works

tim.plunkett’s picture

Status: Reviewed & tested by the community » Needs review
FileSize
14.36 KB
tim.plunkett’s picture

I know its a busy time of year, but I'd really like to get going on this so we can have something usable by January 5th when 7.0 lands.

geerlingguy’s picture

Status: Needs review » Reviewed & tested by the community

Tested all the stuff that's supposed to work in this patch, and it works.

Drag and drop will be nice, but the module's at least ready for an alpha release.

Also, styling looks atrocious (well, pretty ugly in the header area) in Bartik / default D7 install.

aspilicious’s picture

I putted some extra CSS to make it better. Should we put extra css in the project?

Jackinloadup’s picture

This worked for me as well. I think its ready for a release of some kind like a beta.

Drag and Drop support will be nice to add it but it could be another issue.

tim.plunkett’s picture

Status: Reviewed & tested by the community » Active

http://drupal.org/cvs?commit=468968
Now I can fix the drag-n-drop.

geerlingguy’s picture

Nice! Perhaps we could do that in a follow up issue? Or we could keep things nice and tidy in this issue, I guess.

tim.plunkett’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Active » Needs review
FileSize
1.77 KB

Fields now have a $langcode.

tim.plunkett’s picture

Status: Needs review » Fixed

Reviewed by Berdir and dmitrig01 in irc.
http://drupal.org/cvs?commit=469890

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.