Voting starts in March for the Drupal Association Board election.
The title should be hidden if on a node page since the title becomes the page title.
Also noticed that the submitted by isn't checked to see if it's should be displayed of not.
Yep, patch works well, although I see the problem in object.tpl.php as well.
I fixed the logic in tao_preprocess_node(). I think it's better to realize logic in template.php and presentation -- in templates.
New patch is attached.
There are actually two issues here:
* Node and Object templates are printing the title even if it is a page display. Core checks for this in node.tpl.php, taxonomy-term.tpl.php, user-profile.tpl.php. If we are going to check whether $title is set in the tpl.php files, let's just check whether $page is set there, and kepp consistency with core
* Submitted info is being printed regardless of settings in content type UI. This is critical, since it breaks functionality. I have split the issues and there is a separate issue for this bug at #1260954: Submitted information is always printed, and I have set it to Critical and RTBC. I have rerolled ss81 patch and attached it there.
My bad, the Object templates aren't used for user and terms. Only node needs fixing. Here's a patch with the checks ss81 proposed, but checking for $page before checking for $title, since $title will almost always be set and $page evaluates faster.
I tested and committed 932744-tao-hide-title-if-page-6.patch to the 7.x-3.x branch.
Looks good to me, thanks all!
Drupal is a registered trademark of Dries Buytaert.