Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The SelectQuery produced by SelectQuery::countQuery() replaces the connection information in the SelectQuery with the active connection (it uses db_select to form the new query, instead of the select() method of the original query's connection). This caused Drupal to attempt to run a SELECT COUNT(*) query on the wrong database when I was attempting to use Migrate module on an external database.
I marked this Needs Work because I would like someone wiser than I to verify that it should be
$this->connection->select($count) rather than
$count->connection->select($count)
I don't know that it matters, but it seems like it'd be good to check.
| Comment | File | Size | Author |
|---|---|---|---|
| countQueryPatch.patch | 391 bytes | quartsize | |
Comments
Comment #1
quartsize CreditAttribution: quartsize commentedMarking Needs Review, so the testbot will find it (and Crell says $this vs. $count shouldn't make a difference).
Comment #2
Crell CreditAttribution: Crell commentedBoth $count and $this should have identical connection objects at that point, since $count was a clone of $this.
And Bah! that we let that bug creep in there. Thanks, quartsize.
Comment #3
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.