Some modules attempt to preload jCarousel to jQ and after that, when jcarousel tries too, it fails.

This patch solves that.
Patched against v1.1.

Membership dollars fund testing for the Drupal project. Drupal Association Learn more


lpalgarvio’s picture

and for v1.x-dev...

also supplying a second patch with support for jCarousel 0.2.5 (/jcarousel/lib/jquery.jcarousel.jsmin.js changes to /jcarousel/lib/jquery.jcarousel.min.js)

i think it works fine even though we don't have jQuery updated to 1.4.2.
but do test ;)

quicksketch’s picture

Status: Needs review » Needs work

This patch puts the jQ code in the wrong place I think. It should probably be inside of jcarousel_add(), not inside a theme function. The theme layer shouldn't be making adjustments based on whether jQ is available or not.

quicksketch’s picture

Version: 6.x-1.1 » 6.x-2.x-dev
Priority: Major » Normal
Status: Needs work » Postponed

The jQ support no longer exists in the 2.x version of the module. My general opinion of jQ and other attempts to consolidate JavaScript libraries were ill-placed. I'd prefer not to support jQ or any other solution, unless one clearly becomes the defacto-standard. Right now it seems like the attempts sort of peaked around 2009 and then fizzled out. Of course D7 includes "library" support through #attachments, which will probably be the only solution that really gets widespread adoption.

quicksketch’s picture

Status: Postponed » Closed (won't fix)

LPCA is now making the same pitch for Libraries API in #909094: Support libraries directory and Libraries API. jQ, well, can't say I'm surprised it didn't take off.

lpalgarvio’s picture

again, your response wasn't exactly in a timely fashion

obviously the module and your ideals have changed a lot in the past year (September 12, 2010 - October 27, 2011) so my comments might seem silly now.

been so long that i hardly remember what we were discussing here