in function taxonomy_overview_terms(), around line 383 currently reads:

$form[$key]['view'] = array('#value' => l($term->name, "taxonomy/term/$term->tid"));

when it should read:

$form[$key]['view'] = array('#value' => l($term->name, taxonomy_term_path($term)));

Why does it matter? Some modules override the list of terms found: admin/content/taxonomy/% with their own path using the hook_term_path() function.

The patch is attached. I see the issue in d7 too.

CommentFileSizeAuthor
#14 taxonomy-path-928188-15.patch858 bytesmarvin_B8
#12 928188-11.patch745 bytesmarvin_B8
#8 taxonomy.admin_.inc_.patch897 byteselvis2
#6 taxonomy.admin_.inc_.patch925 byteselvis2
#4 928188.patch1.33 KBswentel
#2 taxonomy.admin_.inc_.patch854 byteselvis2
taxonomy.admin_.inc_.patch854 byteselvis2
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

elvis2’s picture

elvis2 CreditAttribution: elvis2 commented
Version: 6.x-dev » 7.x-dev

I changed the version to d7.x since the bug is there too.

elvis2’s picture

elvis2 CreditAttribution: elvis2 commented
FileSize
taxonomy.admin_.inc_.patch854 bytes

Now with patch...

Status: Needs review » Needs work

The last submitted patch, taxonomy.admin_.inc_.patch, failed testing.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Needs work » Needs review
FileSize
928188.patch1.33 KB

Patch should be taken from drupal root and against HEAD. Code is very different with that of D6. New patch.

Status: Needs review » Needs work

The last submitted patch, 928188.patch, failed testing.

elvis2’s picture

elvis2 CreditAttribution: elvis2 commented
Status: Needs work » Needs review
FileSize
taxonomy.admin_.inc_.patch925 bytes

Ok, new patch, from d7 head.

Status: Needs review » Needs work

The last submitted patch, taxonomy.admin_.inc_.patch, failed testing.

elvis2’s picture

elvis2 CreditAttribution: elvis2 commented
Status: Needs work » Needs review
FileSize
taxonomy.admin_.inc_.patch897 bytes

I first line in previous patch was failing simpletest. Let's try again.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Needs work

taxonomy_term_path() doesn't exist in D7, you can use entity_uri() though.

elvis2’s picture

elvis2 CreditAttribution: elvis2 commented

Thanks catch, I will look into it.

marvin_B8’s picture

marvin_B8 CreditAttribution: marvin_B8 commented
Status: Needs work » Needs review
FileSize
928188-11.patch745 bytes

Patch with entity_uri() but looks like a hack

Status: Needs review » Needs work

The last submitted patch, 928188-11.patch, failed testing.

marvin_B8’s picture

marvin_B8 CreditAttribution: marvin_B8 commented
Status: Needs work » Needs review
FileSize
taxonomy-path-928188-15.patch858 bytes
elvis2’s picture

elvis2 CreditAttribution: elvis2 commented
Status: Needs review » Reviewed & tested by the community

@marvin_B8, thanks for working on this.

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein commented
Status: Reviewed & tested by the community » Needs work

taxonomy_term_uri() hardcodes the path also, so this patch doesn't fix the issue. It would indeed need to use entity_uri().

That approach sounds correct to me, but someone should probably check this with the Forum module to see if it actually makes sense. (Since Forum is an example of a module that actually does alter the term path for terms that represent forums, but it may not always make sense to redirect to the actual forum page from all admin pages; maybe this one is sensible though.)