The latest menu changes have caused custom menu blocks not to render any output. If I create a new menu and menu items, and then enable the block, no output from that block is visible.

CommentFileSizeAuthor
#2 fix_custom_menus_0.patch1.01 KBTDobes
#1 fix_custom_menus.patch1021 bytesTDobes
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

TDobes’s picture

TDobes CreditAttribution: TDobes commented
Assigned: Unassigned » TDobes
FileSize
fix_custom_menus.patch1021 bytes

Attached is a patch which fixes the problem: custom menus were being defined as MENU_CUSTOM_ITEM rather than MENU_CUSTOM_MENU.

It also fixes a problem in which custom menus were mistakenly given the MENU_VISIBLE_IN_BREADCRUMB bit when edited. This would cause their titles to show up in the breadcrumb (which is undesirable... only menu items should be in there).

Note that this will not fix any non-functioning custom menus you've defined since this bug appeared. You'll have to delete and recreate them or update the "type" column in the DB manually.

Please review and apply.

TDobes’s picture

TDobes CreditAttribution: TDobes commented
FileSize
fix_custom_menus_0.patch1.01 KB

Small adjustment to make the patch conform to the Drupal code standard. Sorry for bugspam.

JonBob’s picture

JonBob CreditAttribution: JonBob commented

This looks correct to me.

Dries’s picture

Dries CreditAttribution: Dries commented

Committed to HEAD. Thanks.

Anonymous’s picture

(not verified) CreditAttribution: commented