Flat comments displayed as threaded

stevenf,

The problem appears to be that the code in comment.module doesn't check to see if the comment mode is flat before wrapping the comment in a DIV tag that gets formatted as indented. If you replace the code in the module in lines 901-908 with the following, that will fix the problem:

        if ($comment->depth > $last_depth) {
          if ($mode == COMMENT_MODE_THREADED_COLLAPSED or $mode == COMMENT_MODE_THREADED_EXPANDED) {
            $divs++;
            $output .= '<div class="indented">';
          }
        }
        else if ($comment->depth < $last_depth) {
          if ($mode == COMMENT_MODE_THREADED_COLLAPSED or $mode == COMMENT_MODE_THREADED_EXPANDED) {
            $divs--;
            $output .= '</div>';
          }
        }

Here's a patch that fixes the problem.

Patch changes it so the indentation divs are only added for threaded modes.

Bumping to critical since this needs to be fixed for RC1.

Shouldn't the depth remain static if we're not threaded? Meaning those divs should never be applied?

That might simply mean that our *starting* $last_depth is wrong, and assigning $last_depth = 1 could also fix it. Anyone got a testbed that can quickly check me on this?

Allow me to clarify, because apparently I don't make sense today.

In this code, a div is only added if ($comment->depth != $last_depth).

That test should only be true if comments are threaded.

Therefore we should not need to test explicitly as to whether or not comments are threaded. Instead, I believe this means that have $last_depth set incorrectly, which not only means that flat comments are indented, but all comments are indented one extra level whether or not they are threaded.

Also, apparently I am completely wrong about this. In which case webernet's patch looks good.

Tested and works fine.

The patch works right!

Tested and verified. Committed to HEAD. Thanks.