If you use "Store downloaded files" and define a directory that does not exist it does not give any warnings that the directory does not exist so the users think this was OK.
When update then is running it throws a php stream warnings error messages for every po-file that it tries to save. The warnings are also hard for the end user to understand (read)
It then confirm that the import of languages was OK, but did not import any translation strings.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sutharsan’s picture

Version: 6.x-1.0-alpha2 » 6.x-1.x-dev
Status: Active » Needs review
FileSize
1.47 KB

This patch will add submit handler to check for and create a directory the settings form is submitted.
I also revised the description of the download file path.

steinmb’s picture

Status: Needs review » Reviewed & tested by the community

Great work!
Tested and reviewed. Works as expected and the code looks sound.

thePanz’s picture

FileSize
1.62 KB

I suggest using the "_validate" hook, we can then set the right Form item error message (if any).

thePanz’s picture

FileSize
1.64 KB

Updated patch (fixed comment and file_check options)

Sutharsan’s picture

Status: Reviewed & tested by the community » Fixed

Sensible changes, thanks! Patch committed.

thePanz’s picture

Thank you Sutharsan :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.