Add missing languages present on localize.drupal.org

Makes sense, just a note: I don't get if the formatting differences between the cases below are intended.

+++ includes/iso.inc	15 Sep 2010 12:10:19 -0000
@@ -327,6 +328,7 @@ function _locale_get_predefined_list() {
+    'en-gb' => array('English (British)'),

+++ includes/iso.inc	15 Sep 2010 12:10:19 -0000
@@ -413,6 +418,7 @@ function _locale_get_predefined_list() {
+    'pt' => array('Portuguese International'),
     'pt-pt' => array('Portuguese, Portugal', 'Português'),
     'pt-br' => array('Portuguese, Brazil', 'Português'),

Btw, I noticed one of the missing languages is Filipino: in #385296: Standardize the language selector for the Philippine language. we agreed to replace Tagalog with it. Tagalog is not even present on l.d.o. so it seems this is the right choice.

Powered by Dreditor.

Well, if we go this way the two other portugues languages should perhaps changed in "Portuguese, Portuguese" and "Portuguese, Brazilian". Anyway I don't want to stress on formatting, the patch is RTBC besides it, and I ain't even sure it is a real issue.

+++ includes/iso.inc	15 Sep 2010 12:10:19 -0000
@@ -327,6 +328,7 @@ function _locale_get_predefined_list() {
     'en' => array('English'),
+    'en-gb' => array('English (British)'),

This format is inconsistent with others. Elsewhere we'd write 'English, British'.

+++ includes/iso.inc	15 Sep 2010 12:10:19 -0000
@@ -413,6 +418,7 @@ function _locale_get_predefined_list() {
+    'pt' => array('Portuguese International'),
     'pt-pt' => array('Portuguese, Portugal', 'Português'),
     'pt-br' => array('Portuguese, Brazil', 'Português'),

For consistency, this should be: "Portuguese, International" IMO. Can we work with the localize team to get that cleaned up?

+++ includes/iso.inc	15 Sep 2010 12:10:19 -0000
@@ -462,6 +469,7 @@ function _locale_get_predefined_list() {
+    'xx-lolspeak' => array('Lolspeak'),

Really? :)

I'd like to figure out how we can improve consistency of the formatting. In the mean time, let's use something consistent in core.

I don't want to be annoying but since Dries cares about formatting I have a couple of additional questions:

+++ includes/iso.inc	15 Sep 2010 12:10:19 -0000
@@ -413,6 +418,7 @@ function _locale_get_predefined_list() {
+    'pt' => array('Portuguese, International'),
     'pt-pt' => array('Portuguese, Portugal', 'Português'),
     'pt-br' => array('Portuguese, Brazil', 'Português'),

For consistency with "English, British" shouldn't we have these renamed to "Portuguese, Portuguese" and "Portuguese, Brazilian" (or viceversa have "English, Great Britain")?

Moreover I don't get why some languages have the native name and some others don't.

Powered by Dreditor.

@Gábor Hojtsy:

the missing items are not there for historic reasons

Thanks for the info.

I can't believe that I'm actually committing a patch to core that includes the string "Lolspeak", but there you go.

Committed to HEAD. ;)

But this does raise an interesting point. I assume that localize.drupal.org will continue to evolve and gain more languages, which means more patches like this are inevitable in 7.1, 7.2... are these considered acceptable string freeze breakages? I assume so, since the freaking Drupal 6 maintainer uploaded a D6 patch up above. But we might want to document this somewhere.

Moving to D6.

“English, British” just looks plain wrong. It should be either “English (Great Britain)” or British English. As for Lolspeak, should it not be “LOLspeak” or even “LOLspeek”?

And for consistency, I think we should use parentheses for German (Switzerland) and Portuguese (Internatioal) (and the rest of them) as well.

I would just like to go on record stating that Professor Elfinugget has entirely too much time on his or her hands.

#16: I stand corrected on the Swiss German part. I just remembered that it is called “Schweizerdeutsch” in German, indicating that it is indeed rather different. Wikipedia sums it up very well: “The dialects of Swiss German must not be confused with Swiss Standard German, the variety of Standard German used in Switzerland.”

As for LOLspeak, while that site has a mix of capitalisations, LOLspeak seems to be the most prevalent.

In any case, I still think “English, British” is horrible.

As a developer and an enthusiastic member of the Drupal community I like the idea of Lolspeak in core, but from a marketing perspective I think this is a no go. Drupal has become too popular to make the product itself funny. Languages on l.d.o are user-contributed, so it's fine to add Lolspeak and Klingon there, but in Drupal core we should stick to official (modern) languages.

Changes are performed in the development version first, backported then.

Fixed HTML format

This issue was committed to Drupal 6.x along time ago. It was reopened to discuss the Drupal 7 version. Looking at the current version of the file in Drupal 7, the changes are there.

I am closing this as outdated.