Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The ImageFlow Options tab in views is growing quite long, and I see several feature requests, both open and closed, for specific functionality. What I would suggest (and like for my own use) is a text box, in which I can enter options to be passed to the ImageFlow init function.
A single box, where a user can enter options as text, would add a great deal of functionality to the module - there are a dozen or more options that ImageFlow supports but the module doesn't yet.
Unfortunately, my PHP is quite poor, so I can't write a patch myself.
Comment | File | Size | Author |
---|---|---|---|
#7 | imageflow_extra_options-907260-2.patch | 6.11 KB | adrinux |
#6 | imageflow_extra_options-907260-1.patch | 6.11 KB | adrinux |
Comments
Comment #1
SteveViselli CreditAttribution: SteveViselli commentedHi,
I don't think a text box for entering options would be a great idea, it leaves to much chance for user error. Not to mention it's a huge security flaw. Some Drupal modules have options lists 10x as long as the current ImageFlow options list, it's not that uncommon.
I recently patched the module to include circular functionality, and I'm planning to work my way through the list of other features ImageFlow supports. In the mean time, you can use my patch (http://drupal.org/node/891268) as an example of how to add support for another ImageFlow option.
Steve
Comment #2
threewestwinds CreditAttribution: threewestwinds commentedI'm afraid I don't see how it's a security flaw any worse than the onClickOverride box is. They would basically do the same thing - take a text string and pass it to the ImageFlow init call.
I'd like the box as a supplement for existing options, rather than a replacement. Call is "Advanced Options" or something. but if you're going to work your way through the ImageFlow options, this would only be a place holder.
I'm not real great with PHP, so I've actually been modding the javascript side of things to meet a deadline. I am indeed using the circular patch you linked to. Thanks for that. Any chance that sildeshow, slideshowAutoplay and slideshowSpeed might be next so I can revert to unmodified js files? ;)
-Peter
Comment #3
SteveViselli CreditAttribution: SteveViselli commentedSure thing Peter, I'll make sure I get those features working in my next patch. Shouldn't take too long.
Steve
Comment #4
akalata CreditAttribution: akalata commentedHey Steve,
Are you interested in collaborating on including more options from ImageFlow into the Views Slideshow style/settings panel?
I was able to use your patch for Circular to dig into the code and get the slideshow options working; would love to contribute to a more complete solution.
Here are the basic groupings I have so far:
Comment #5
broncomania CreditAttribution: broncomania commentedsubscribe is a patch available ?
Comment #6
adrinux CreditAttribution: adrinux commentedI've added scrollbar 'buttons' support to @SteveViselli's circular patch from http://drupal.org/node/891268 – so I think this is a more appropriate issue for my patch than that. It's not all the features listed in #4, but it's a start.
Patch against git 6.x-2.x branch attached.
Comment #7
adrinux CreditAttribution: adrinux commentedUpdated patch to fix a stupid error checking settings on existing views.
Comment #8
jefbak2 CreditAttribution: jefbak2 commentedSubscribing as we would need this option:
Slideshow [slideshow, slideshowSpeed, slideshowAutoplay]
But I don't have shell access to the server (just the ability to add modules via ftp), how can I add the patch?
Comment #9
threewestwinds CreditAttribution: threewestwinds commentedYou could extract a local copy of the module, apply the patch to that, re-zip the module folder, then upload the zip file as a module.
Comment #10
Shiraz Dindarthe patch wouldn't apply to the latest dev as of this date... is it working on the latest for others?
so i went ahead an applied the patch manually. the options showed up -- i checked both circular and buttons options, but neither worked (simply didn't change the view)... i was fairly careful about the manual application, don't think i missed anything... waiting to hear if anyone else has had success...
cheers
Comment #11
ytsejam CreditAttribution: ytsejam commentedThe patch works for me with the latest dev, thanks for it!
Comment #12
aze2010 CreditAttribution: aze2010 commentedsubscribing for slideshow, slideshowSpeed, slideshowAutoplay
This would be sooooooooooooooooooo great!
Thanks for this module!!!