1) After applying update #6200 of config_perms module 6.x from 1.0 to 2.0-beta2, following error messages occur:
* warning: array_merge() [function.array-merge]: Argument #2 is not an array in /home2/danstang/public_html/update.php on line 174.
* warning: Invalid argument supplied for foreach() in /home2/danstang/public_html/update.php on line 338.

2) If the module has been already installed and possibly uninstalled (in the past), then during installation the error appears stating that the table config_perms already exists in /{path}/includes/database.inc on line 555. In such case, records are ADDED to the table, even if those records are the same (except for the primary key). Apparently, uninstalling doesn't empty nor remove aforementioned table. It is Drupal's policy that uninstalling (NOT: disabling) modules should delete any data created by that module. NB: With the previous branch the table does not exist and with the current/ latest branch the table does exist.

3) As role management is integrated in Drupal core and to prevent confusion regarding security sensitive settings, please remove:
a) the 'administer site configuration' permission under the 'system module' in '{domain}/admin/user/permissions' and
b) following text in '{domain}/admin/settings/config_perms':
"Any role without 'administer site configuration' will be granted access to whatever permissions checked in the config_perms section of the permissions page. So in other words, if you want grant roles only a few of theses items, uncheck 'administer site configuration', check one or both of the display permissions, and check whatever you want them to have access to."

4) Adding a custom permission via '{domain}/admin/settings/config_perms' with:
a) name 'administer themes global settings' and path 'admin/build/themes/settings' and DISABLING that permission for a role via '{domain}/admin/user/permissions' does NOT PREVENT such role from accessing aforementioned path. NB: so, a path WITHOUT postfixed slash.
b) name 'administer theme specific settings' and path 'admin/build/themes/settings/' and ENABLING that permission for a role via '{domain}/admin/user/permissions' does NOT ALLOW such role from accessing aforementioned path. NB: so, a path WITH postfixed slash.
NB: 4a & 4b re-open following issue: http://drupal.org/node/760356

5) In '{domain}/admin/user/permissions', the 'display site building/ configuration menu' permission SHOULD cause that menu-item to appear, also when the 'access administration pages' permission is DISabled. It should do so without modifying access rights for any sub-items under aforementioned menu-item, obviously. The 'access administration pages' permission would be way too powerful for this.

Under '{domain}/admin/settings/config_perms':
6a) Include a link within the configuration instructions to '{domain}/admin/user/permissions'.
6b) Sort the table alphabetically by default, based on the 'Name' column (similar to '{domain}/admin/user/permissions').
6c) Change the checkbox "Delete" into buttons like the "Add" button per record, to prevent confusion.

Comments

not_Dries_Buytaert’s picture

4c) A dynamic permission is missing to allow or deny roles to configure any enabled (!) theme: {domain}/admin/build/themes/settings/{enabled theme}

Docc’s picture

Thanx for the issue.
Didn't had much time to debug it myself. So its appreciated.

Ill pick this up soon and respond appropriate to your issue list.

alb’s picture

regard the point

5) ... permission SHOULD cause that menu-item to appear, also when the 'access administration pages' permission is DISabled. It should do so without modifying access rights for any sub-items under aforementioned menu-item, obviously. ...

but is a core module problem?
I ask because for all modules (a first example: block), when I enable permission, isn't the link in the menu, so is necessary to activate also "access administration pages" but so appear all the
administer's menu:
* Content management
* Site building
* Site configuration
* User management
* Help

and isn't good;

only permission create page(story, ...) content haven't this problem;
in drupal 5 there wasn't this problem;
how you activate a permission you see the link directly and not under administer's menu

Docc’s picture

Status: Active » Closed (works as designed)

6.x wont be seeing any functionality changes. Only bugfixes
Im focusing on 7.x. We can always backport.

So if any of these issues still exist post a separet issue.