Clean up E_NOTICE warnings [#883866]

Tried to upgrade from beta 5 version to to the latest and I get a slew of errors like this. Thoughts?

Notice: Undefined index: spacing in H:\wamp\www\assumptiongrad_drupal\sites\all\themes\omega\template.php on line 159

Notice: Undefined index: preface_wrapper_grids in H:\wamp\www\assumptiongrad_drupal\sites\all\themes\omega\preprocess\preprocess-page.inc on line 94

Notice: Undefined index: spacing in H:\wamp\www\assumptiongrad_drupal\sites\all\themes\omega\template.php on line 219

Notice: Undefined index: primary in H:\wamp\www\assumptiongrad_drupal\sites\all\themes\omega\template.php on line 201

Notice: Undefined index: primary in H:\wamp\www\assumptiongrad_drupal\sites\all\themes\omega\template.php on line 202

Notice: Undefined index: spacing in H:\wamp\www\assumptiongrad_drupal\sites\all\themes\omega\template.php on line 219

Notice: Undefined index: postscript_container_width in H:\wamp\www\assumptiongrad_drupal\sites\all\themes\omega\preprocess\preprocess-page.inc on line 320

Notice: Undefined index: spacing in H:\wamp\www\assumptiongrad_drupal\sites\all\themes\omega\template.php on line 159

Comment	File	Size	Author
#6	omega.e_notice_warnings_883866_06.patch	4.53 KB	rfay
#5	omega.e_notice_warnings_883866_05.patch	3.96 KB	rfay

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

himerus CreditAttribution: himerus commented 17 August 2010 at 16:06

hrm... I'm not sure what changes between Beta 5 and 11 would have immediately caused this.

Have you flushed all caches, including theme registry, and visited the theme settings form and ensured everything is set properly and save that again?

Comment #2

himerus CreditAttribution: himerus commented 25 August 2010 at 07:04

Any update here Greg??! (hello from Copenhagen!!)

Comment #3

rfay

English

Palisade, CO, USA

CreditAttribution: rfay commented 13 September 2010 at 22:01

Title:	update issues.	» Numerous warnings with current 6.x
Version:	6.x-1.0-beta11	» 6.x-1.x-dev

Lots of warnings on every page when Omega is enabled and using a dev version of Drupal 6 (with E_NOTICE enabled). These should be cleaned up.

    * notice: Undefined index: base theme in /home/rfay/workspace/d6git/modules/system/system.module on line 942.
    * notice: Undefined property: stdClass::$base_theme in /home/rfay/workspace/d6git/sites/all/themes/omega/template.php on line 27.
    * notice: Undefined index: spacing in /home/rfay/workspace/d6git/sites/all/themes/omega/template.php on line 140.
    * notice: Undefined index: spacing in /home/rfay/workspace/d6git/sites/all/themes/omega/template.php on line 140.
    * notice: Undefined index: preface_wrapper_grids in /home/rfay/workspace/d6git/sites/all/themes/omega/preprocess/preprocess-page.inc on line 94.
    * notice: Undefined index: spacing in /home/rfay/workspace/d6git/sites/all/themes/omega/template.php on line 200.
    * notice: Undefined index: primary in /home/rfay/workspace/d6git/sites/all/themes/omega/template.php on line 182.
    * notice: Undefined index: primary in /home/rfay/workspace/d6git/sites/all/themes/omega/template.php on line 183.
    * notice: Undefined index: spacing in /home/rfay/workspace/d6git/sites/all/themes/omega/template.php on line 200.
    * notice: Undefined index: spacing in /home/rfay/workspace/d6git/sites/all/themes/omega/template.php on line 200.
    * notice: Undefined index: postscript_container_width in /home/rfay/workspace/d6git/sites/all/themes/omega/preprocess/preprocess-page.inc on line 320.
    * notice: Undefined index: spacing in /home/rfay/workspace/d6git/sites/all/themes/omega/template.php on line 140.
    * notice: Undefined index: spacing in /home/rfay/workspace/d6git/sites/all/themes/omega/template.php on line 140.
    * notice: Undefined variable: mission in /home/rfay/workspace/d6git/sites/all/themes/omega/page.tpl.php on line 105.
    * notice: Undefined index: omega_fixed_fluid in /home/rfay/workspace/d6git/sites/all/themes/omega/theme-settings.php on line 248.
    * notice: Undefined index: node_info in /home/rfay/workspace/d6git/sites/all/modules/omega_tools/omega_tools.module on line 42.
    * notice: Undefined index: node_info in /home/rfay/workspace/d6git/sites/all/modules/omega_tools/omega_tools.module on line 42.
    * notice: Undefined index: base theme in /home/rfay/workspace/d6git/modules/system/system.module on line 942.
    * notice: Undefined property: stdClass::$base_theme in /home/rfay/workspace/d6git/sites/all/themes/omega/template.php on line 27.
    * notice: Undefined index: base theme in /home/rfay/workspace/d6git/modules/system/system.module on line 942.
    * notice: Undefined property: stdClass::$base_theme in /home/rfay/workspace/d6git/sites/all/themes/omega/template.php on line 27.
    * notice: Undefined index: base theme in /home/rfay/workspace/d6git/modules/system/system.module on line 942.
    * notice: Undefined property: stdClass::$base_theme in /home/rfay/workspace/d6git/sites/all/themes/omega/template.php on line 27.
    * notice: Undefined index: base theme in /home/rfay/workspace/d6git/modules/system/system.module on line 942.
    * notice: Undefined property: stdClass::$base_theme in /home/rfay/workspace/d6git/sites/all/themes/omega/template.php on line 27.

Comment #4

rfay

English

Palisade, CO, USA

CreditAttribution: rfay commented 13 September 2010 at 22:35

Title:

Numerous warnings with current 6.x

» Clean up E_NOTICE warnings

Comment #5

rfay

English

Palisade, CO, USA

CreditAttribution: rfay commented 13 September 2010 at 23:25

Status:

Active

» Needs review

File	Size
omega.e_notice_warnings_883866_05.patch	3.96 KB

I think this patch resolves those issues. There are a couple of assignments there that will now happen that would not have before, so should look at those carefully (changed from $settings to $vars). For a long time, those were just errors.

Comment #6

rfay

English

Palisade, CO, USA

CreditAttribution: rfay commented 13 September 2010 at 23:30

File	Size
omega.e_notice_warnings_883866_06.patch	4.53 KB

Oops - found one more in the page.tpl.php of the starterkit.

Comment #7

himerus CreditAttribution: himerus commented 15 September 2010 at 21:53

Thank you for this.... I will test the patch here shortly.

These issues were resolved in D7 as the default setting was to display E_NOTICE warnings by default.
If this works on my sandbox with E_NOTICE enabled, and can verify it didn't adversely effect anything else, we'll be good, and I'll push this.