Module does not update parent item's has_children field on taxonomy menu deletion [#882126]

When a taxonomy menu is deleted, the _taxonomy_menu_delete_all function is called.
The way this function works should be rethought as it directly delete rows from the menu_links table instead of using core menu.inc functions.
Deleting rows from the table is not enough.
This way, the item that was containing the taxonomy menu before its deletion is not updated. Thus, its has_children status stays the same, and the item without children keeps showing as collapsed instead of leaf.

Comment	File	Size	Author
#7	taxonomy_menu-use_menu_api-882126-7.patch	1.17 KB	jenlampton
#7	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 5 pass
#3	issue-882126-Module-does-not-update-parent-items-has.patch	1.02 KB	Leon Kessler
#3

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

dstol

English

CreditAttribution: dstol commented 9 March 2011 at 05:30

Status:

Active

» Closed (fixed)

Comment #2

anrikun CreditAttribution: anrikun commented 9 March 2011 at 10:47

Can you tell me in which version this is fixed? in dev?

Comment #3

Leon Kessler CreditAttribution: Leon Kessler commented 25 October 2012 at 16:12

Status:

Closed (fixed)

» Needs review

File	Size
issue-882126-Module-does-not-update-parent-items-has.patch	1.02 KB

This has definitely not been fixed. No idea why it was closed.

I've created a patch that runs the delete through taxonomy_menu_handler(), so that it uses the standard hook_taxonomy_menu_delete() which in turn uses menu_link_delete. The correct way (the way I assumed it would work, not sure why it was done differently, if someone know's please say).

The patch also updates the taxonomy_menu_handler() function so that it handles delete operations properly according to the function definition.

Thanks
Leon