Configurable location for mp3players external files. [#880050]

It would be great if this module supported the ability to place the player.swf and audio-player.js files into a directory of my own choice, I prefer to have all my external libraries in a sites/all/libraries directory.

I also don't like how this module has to check for the files on every page load, that really the job of hook_requirements()

Attached is a patch to address these issues.

Comment	File	Size	Author
#5	mp3player-880050-5.patch	4.6 KB	joestewart
#4	880050-libraries.patch	4.59 KB	joestewart
	mp3player.patch	4.86 KB	univate

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

univate CreditAttribution: univate commented 11 August 2010 at 13:42

Status:

Active

» Needs review

Comment #2

dkingofpa CreditAttribution: dkingofpa commented 19 October 2010 at 15:16

Used the patch with 1.x-dev. Works as expected. Thanks for saving me some time!

Comment #3

gorbeia CreditAttribution: gorbeia commented 19 October 2010 at 20:25

This patch makes 'sites/all/modules/mp3player/mp3player' the default path but the module can be installed in other directories. It makes more sense to use drupal_get_path('module', 'mp3player') instead.

Comment #4

joestewart CreditAttribution: joestewart commented 2 December 2010 at 16:59

File	Size
880050-libraries.patch	4.59 KB

rerolled patch as per #3.

Comment #5

joestewart CreditAttribution: joestewart commented 4 December 2010 at 12:44

File	Size
mp3player-880050-5.patch	4.6 KB

maybe without my typos this time.

Comment #6

joachim CreditAttribution: joachim commented 7 January 2011 at 16:42

Status:

Needs review

» Needs work

Powered by Dreditor.

+++ ./mp3player.module	2010-12-02 10:55:56.000000000 -0600
@@ -147,6 +147,13 @@ function mp3player_players($pid = NULL) 
+      '#default_value' => variable_get('mp3player_library_path', drupal_get_path('module', 'mp3player')) . '/mp3player'),

Too many closing )s here, and not entirely sure what is meant.

Also, as a follow-on, there's #936032: Move drupal_add_js to theme function, in which the drupal_add_js() calls should be moved to the theme function rather than be always loaded in hook_init().

Powered by Dreditor.