Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
It would be great if this module supported the ability to place the player.swf and audio-player.js files into a directory of my own choice, I prefer to have all my external libraries in a sites/all/libraries directory.
I also don't like how this module has to check for the files on every page load, that really the job of hook_requirements()
Attached is a patch to address these issues.
Comment | File | Size | Author |
---|---|---|---|
#5 | mp3player-880050-5.patch | 4.6 KB | joestewart |
#4 | 880050-libraries.patch | 4.59 KB | joestewart |
mp3player.patch | 4.86 KB | univate |
Comments
Comment #1
univate CreditAttribution: univate commentedComment #2
dkingofpa CreditAttribution: dkingofpa commentedUsed the patch with 1.x-dev. Works as expected. Thanks for saving me some time!
Comment #3
gorbeia CreditAttribution: gorbeia commentedThis patch makes 'sites/all/modules/mp3player/mp3player' the default path but the module can be installed in other directories. It makes more sense to use drupal_get_path('module', 'mp3player') instead.
Comment #4
joestewart CreditAttribution: joestewart commentedrerolled patch as per #3.
Comment #5
joestewart CreditAttribution: joestewart commentedmaybe without my typos this time.
Comment #6
joachim CreditAttribution: joachim commentedPowered by Dreditor.
Too many closing )s here, and not entirely sure what is meant.
Also, as a follow-on, there's #936032: Move drupal_add_js to theme function, in which the drupal_add_js() calls should be moved to the theme function rather than be always loaded in hook_init().
Powered by Dreditor.
Comment #7
jdelaune CreditAttribution: jdelaune commentedCommitted to dev branch. Thanks.