Adding a hook that is not namespaced with the module's name is a serious collision problem.

og_menu has a function called og_menu_get_menus, so that using it with menu_block results in errors like warning: preg_match() expects parameter 2 to be string, array given in /webroot/includes/bootstrap.inc on line 777. (this choke is on the use of t() after calling menu_block_get_all_menus().)

So that's one collision, but certainly others may exist.

Related to this, I see there is a book_get_menus function, and that's another namespace problem.

Comments

JohnAlbin’s picture