Vertical Tabs is integrated in Drupal 7 and in D6 is a contrib module.

This patch adds support for vertical tabs for the administration settings form and it should be valid for D7 as well.
It doesn't affect if you don't have vertical tabs installed.

CommentFileSizeAuthor
#7 pathauto_vt_summaries-D7.png41.5 KBjcmarco
#7 pathauto_admin_vt_summaries-D7.patch4.05 KBjcmarco
#5 d7_pathauto_patterns_1.png155.71 KBjcmarco
#5 d7_pathauto_patterns_2.png155 KBjcmarco
#5 d7_pathauto_patterns_3.png152.7 KBjcmarco
#2 pathauto_admin_vt-D7.patch724 bytesjcmarco
pathauto_vt.patch1.11 KBjcmarco
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Needs work

Vertical tabs need summaries to be useful, so the patch will need to add those likely with a new pathauto.admin.js file. Plus new features go into 7.x-1.x and are backported to 6.x-2.x only.

jcmarco’s picture

jcmarco CreditAttribution: jcmarco commented
Status: Needs work » Needs review
FileSize
pathauto_admin_vt-D7.patch724 bytes

This is the patch for D7.
It is really hard imagine what information put in the summaries.
Also the new tabs organization only allow using the vertical tabs integration with the patterns settings and not the rest.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Needs review » Needs work

Yeah this really, really needs summaries to comply with our UX standards.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented

@jcmarco - can you post a screenshot as well?

jcmarco’s picture

jcmarco CreditAttribution: jcmarco commented
FileSize
d7_pathauto_patterns_3.png152.7 KB
d7_pathauto_patterns_2.png155 KB
d7_pathauto_patterns_1.png155.71 KB

These are the images for the patterns options

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented

I mostly agree with Dave, we need a summary on the tab to follow the pattern used elsewhere in core. But what should that summary be? A count of the fields with settings? The settings for the fields truncated after X characters?

jcmarco’s picture

jcmarco CreditAttribution: jcmarco commented
Status: Needs work » Needs review
FileSize
pathauto_admin_vt_summaries-D7.patch4.05 KB
pathauto_vt_summaries-D7.png41.5 KB

This version adds the vertical tabs summaries.

Some other changes are:
- fieldsets names contextualized for pathauto.
- instead showing the mega super huge token help table on each tab, show it only once at the bottom.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Needs review » Needs work

Note that the patch only lists the last token type (user) in the token tree, and not all possible token types that it needs to list (node, term, and user).